[GitHub] [hbase] wchevreuil commented on a change in pull request #2982: HBASE-25603 Add switch for compaction after bulkload

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2982:
URL: https://github.com/apache/hbase/pull/2982#discussion_r582043340



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -7025,19 +7025,23 @@ String prepareBulkLoad(byte[] family, String srcPath, boolean copyFile)
       }
 
       isSuccessful = true;
-      //request compaction
-      familyWithFinalPath.keySet().forEach(family -> {
-        HStore store = getStore(family);
-        try {
-          if (this.rsServices != null && store.needsCompaction()) {
-            this.rsServices.getCompactionRequestor().requestCompaction(this, store,
-              "bulkload hfiles request compaction", Store.PRIORITY_USER + 1,
-              CompactionLifeCycleTracker.DUMMY, null);
+      if (conf.getBoolean(HConstants.COMPACTION_AFTER_BULKLOAD_ENABLE, false)) {

Review comment:
       Shouldn't it be enabled by default, to keep consistent with previous behaviour?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org