You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/31 14:08:00 UTC
[jira] [Commented] (FLINK-7314) Remove Flink's futures from
TaskManagerLogHandler
[ https://issues.apache.org/jira/browse/FLINK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107347#comment-16107347 ]
ASF GitHub Bot commented on FLINK-7314:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4430
[FLINK-7314] [futures] Replace Flink's futures with CompletableFuture in TaskManagerLogHandler
## What is the purpose of the change
Replaces Flink's `Futures` with `CompletableFuture` in `TaskManagerLogHandler`.
This PR is based onto #4429.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink replaceFutures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4430
----
commit afe1d171132bb3724e672a1c4ce74a3f7c185908
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-31T13:07:18Z
[FLINK-7313] [futures] Add Flink future and Scala future to Java 8 CompletableFuture conversion
Add DirectExecutionContext
Add Scala Future to Java 8 CompletableFuture utility to FutureUtils
Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils
Add base class for Flink's unchecked future exceptions
commit ace412d9cfc449288bfcaa43e6f3b52bcdefc6f2
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-31T13:53:48Z
[FLINK-7314] [futures] Replace Flink's futures with CompletableFuture in TaskManagerLogHandler
----
> Remove Flink's futures from TaskManagerLogHandler
> -------------------------------------------------
>
> Key: FLINK-7314
> URL: https://issues.apache.org/jira/browse/FLINK-7314
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)