You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:49:20 UTC

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3690: [compaction] Update cumulative point calculate algorithm

acelyc111 opened a new pull request #3690:
URL: https://github.com/apache/incubator-doris/pull/3690


   Ref https://github.com/apache/incubator-doris/issues/3687
   Current cumulative point calculate algorithm may skip sigleton version
   rowset when the rowset has only one segment and with NONOVERLAPPING flag.
   When a tablet is new created and cumulate many singleton version rowsets,
   cumulative point will be calculated as the max version + 1, and then
   cumulative compaction couldn't pick any rowsets and compaction failed, and
   will lead the next base compaction on this tablet with all rowsets, which
   can also cause memory consume problem, suppose there are thousands of rowsets.
   
   All sigleton version rowsets must be newly wrote by delta writer and hasn't
   do any compaction, we should place cumulative point before any of these rowsets.
   And also we should store cumulative point into tablet meta.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3690: [compaction] Update cumulative point calculate algorithm

Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3690:
URL: https://github.com/apache/incubator-doris/pull/3690#discussion_r431543771



##########
File path: be/src/olap/tablet.cpp
##########
@@ -68,7 +68,7 @@ Tablet::Tablet(TabletMetaSharedPtr tablet_meta, DataDir* data_dir) :
         _last_base_compaction_failure_millis(0),
         _last_cumu_compaction_success_millis(0),
         _last_base_compaction_success_millis(0),
-        _cumulative_point(kInvalidCumulativePoint) {
+        _cumulative_point(tablet_meta->cumulative_layer_point()) {

Review comment:
       cumulative point in tablet meta has non-sense. 
   If will cause another persistence for clone/compaction.
   So it's removed from tablet meta when refactoring BE.
   You can see it because of compatibility for the old code path. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] chaoyli merged pull request #3690: [compaction] Update cumulative point calculate algorithm

Posted by GitBox <gi...@apache.org>.
chaoyli merged pull request #3690:
URL: https://github.com/apache/incubator-doris/pull/3690


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3690: [compaction] Update cumulative point calculate algorithm

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #3690:
URL: https://github.com/apache/incubator-doris/pull/3690#discussion_r431654202



##########
File path: be/src/olap/tablet.cpp
##########
@@ -68,7 +68,7 @@ Tablet::Tablet(TabletMetaSharedPtr tablet_meta, DataDir* data_dir) :
         _last_base_compaction_failure_millis(0),
         _last_cumu_compaction_success_millis(0),
         _last_base_compaction_success_millis(0),
-        _cumulative_point(kInvalidCumulativePoint) {
+        _cumulative_point(tablet_meta->cumulative_layer_point()) {

Review comment:
       Reverted these changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org