You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/12/06 19:13:24 UTC

[GitHub] [incubator-heron] xiaoyao1991 commented on a change in pull request #3412: [WIP] make python code compatible with both python2 and python3

xiaoyao1991 commented on a change in pull request #3412: [WIP] make python code compatible with both python2 and python3
URL: https://github.com/apache/incubator-heron/pull/3412#discussion_r354988164
 
 

 ##########
 File path: heron/shell/src/python/handlers/killexecutorhandler.py
 ##########
 @@ -20,10 +20,13 @@
 
 
 ''' killexecutorhandler.py '''
+from future.standard_library import install_aliases
+install_aliases()
+
 import logging
 import os
 import signal
-import urlparse
+from urllib.parse import parse_qsl
 
 Review comment:
   Looks like this is a package only valid in py3? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services