You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "TJaniF (via GitHub)" <gi...@apache.org> on 2024/08/26 08:57:58 UTC
[PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
TJaniF opened a new pull request, #41744:
URL: https://github.com/apache/airflow/pull/41744
A suggestion to clarify that it is only the parameters that are experimental, not the methods themselves because the current docstring caused confusion around that :)
I hope my wording makes sense here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
Posted by "TJaniF (via GitHub)" <gi...@apache.org>.
TJaniF commented on code in PR #41744:
URL: https://github.com/apache/airflow/pull/41744#discussion_r1730964379
##########
airflow/models/baseoperator.py:
##########
@@ -714,12 +714,14 @@ class derived from this one results in the creation of a task object,
execution, receiving a context dictionary; raising an exception will
prevent the task from being executed.
- |experimental|
+ |experimental| Passing a function to this argument is experimental, although
+ (re-)implementing ``pre_execute`` in a custom operator subclass is stable.
:param post_execute: a function to be called immediately after task
execution, receiving a context dictionary and task result; raising an
exception will prevent the task from succeeding.
- |experimental|
+ |experimental| Note that passing a function to the post_execute parameter is experimental,
Review Comment:
```suggestion
|experimental| Passing a function to this argument is experimental, although
(re-)implementing ``post_execute`` in a custom operator subclass is stable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41744:
URL: https://github.com/apache/airflow/pull/41744#issuecomment-2406264349
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
Posted by "TJaniF (via GitHub)" <gi...@apache.org>.
TJaniF commented on code in PR #41744:
URL: https://github.com/apache/airflow/pull/41744#discussion_r1730965227
##########
airflow/models/baseoperator.py:
##########
@@ -714,12 +714,14 @@ class derived from this one results in the creation of a task object,
execution, receiving a context dictionary; raising an exception will
prevent the task from being executed.
- |experimental|
+ |experimental| Note that passing a function to the pre_execute parameter is experimental,
+ while overriding .pre_execute in a custom operator is stable.
Review Comment:
Thank you! Yes, I agree, implementing is probably the more common term :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #41744:
URL: https://github.com/apache/airflow/pull/41744#discussion_r1730956484
##########
airflow/models/baseoperator.py:
##########
@@ -714,12 +714,14 @@ class derived from this one results in the creation of a task object,
execution, receiving a context dictionary; raising an exception will
prevent the task from being executed.
- |experimental|
+ |experimental| Note that passing a function to the pre_execute parameter is experimental,
+ while overriding .pre_execute in a custom operator is stable.
Review Comment:
```suggestion
|experimental| Passing a function to this argument is experimental, although
(re-)implementing ``pre_execute`` in a custom operator subclass is stable.
```
This is probably a little better? It might still be confusing to some users what *overriding* means. Not sure TBH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify language in BaseOperator docstring about pre_execute and post_execute parameter [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #41744: Clarify language in BaseOperator docstring about pre_execute and post_execute parameter
URL: https://github.com/apache/airflow/pull/41744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org