You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/12/30 23:56:02 UTC

[PR] Feature/509 remove embedded bundles support (celix)

pnoltes opened a new pull request, #707:
URL: https://github.com/apache/celix/pull/707

   This PR removes support for embedded bundles.
   
   Although embedding bundles as part of an executable is interesting, it is not part of the OSGi spec and it is proven that this requires some maintenance effort (cmake changes, use of assembly, security changes, etc). 
   
   Maybe in the future something like a executable (far) jar from bndtools can be adopted for Apache Celix:
   > Bndtools can export a bndrun file to an executable JAR. This is a JAR that can be executed in any Java VM. The JAR contains the framework and all required bundles. When it runs with the venerable java -jar x.jar command it will unpack itself and launch a framework. The continuous integration can build this executable JAR.
   
   So an executable that contains and extracts the Apache Celix container executable, its required bundles and possible some libs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/509 remove embedded bundles support (celix)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #707:
URL: https://github.com/apache/celix/pull/707#issuecomment-1872629907

   ## [Codecov](https://app.codecov.io/gh/apache/celix/pull/707?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`9ea03bc`)](https://app.codecov.io/gh/apache/celix/commit/9ea03bc620760e2866f743d24ecbdcd1289aaff2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 88.39% compared to head [(`07bf252`)](https://app.codecov.io/gh/apache/celix/pull/707?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 88.35%.
   
   > :exclamation: Current head 07bf252 differs from pull request most recent head 4224357. Consider uploading reports for the commit 4224357 to get more accurate results
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #707      +/-   ##
   ==========================================
   - Coverage   88.39%   88.35%   -0.05%     
   ==========================================
     Files         215      215              
     Lines       24618    24500     -118     
   ==========================================
   - Hits        21762    21646     -116     
   + Misses       2856     2854       -2     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celix/pull/707?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/509 remove embedded bundles support (celix)

Posted by "rlenferink (via GitHub)" <gi...@apache.org>.
rlenferink commented on PR #707:
URL: https://github.com/apache/celix/pull/707#issuecomment-1873490613

   > Maybe in the future something like a executable (far) jar from bndtools can be adopted for Apache Celix
   
   @pnoltes if this is an idea for the future, I think it would be wise to create an issue for it with a brief explanation of the wish (and possibly referring to this PR as well)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/509 remove embedded bundles support (celix)

Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes merged PR #707:
URL: https://github.com/apache/celix/pull/707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org