[GitHub] [kvrocks] PragmaTwice commented on a diff in pull request #1605: Fix make warning on GCC

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1605:
URL: https://github.com/apache/kvrocks/pull/1605#discussion_r1276082893


##########
cmake/lua.cmake:
##########
@@ -34,10 +34,17 @@ if(NOT lua_POPULATED)
     set(LUA_CFLAGS "${LUA_CFLAGS} -isysroot ${CMAKE_OSX_SYSROOT}")
   endif()
 
-  add_custom_target(make_lua COMMAND make "CC=${LUA_CXX}" "CFLAGS=${LUA_CFLAGS}" liblua.a
-    WORKING_DIRECTORY ${lua_SOURCE_DIR}/src
-    BYPRODUCTS ${lua_SOURCE_DIR}/src/liblua.a
-  )
+  if(CMAKE_GENERATOR STREQUAL "Ninja")
+    add_custom_target(make_lua COMMAND make "CC=${LUA_CXX}" "CFLAGS=${LUA_CFLAGS}" liblua.a
+      WORKING_DIRECTORY ${lua_SOURCE_DIR}/src
+      BYPRODUCTS ${lua_SOURCE_DIR}/src/liblua.a
+    )
+  else()
+    add_custom_target(make_lua COMMAND $(MAKE) "CC=${LUA_CXX}" "CFLAGS=${LUA_CFLAGS}" liblua.a
+      WORKING_DIRECTORY ${lua_SOURCE_DIR}/src
+      BYPRODUCTS ${lua_SOURCE_DIR}/src/liblua.a
+    )
+  endif()

Review Comment:
   ```suggestion
     if(CMAKE_GENERATOR STREQUAL "Ninja")
       set(MAKE_COMMAND make)
     else()
       set(MAKE_COMMAND $(MAKE))
     endif()
     add_custom_target(make_lua COMMAND ${MAKE_COMMAND} "CC=${LUA_CXX}" "CFLAGS=${LUA_CFLAGS}" liblua.a
       WORKING_DIRECTORY ${lua_SOURCE_DIR}/src
       BYPRODUCTS ${lua_SOURCE_DIR}/src/liblua.a
     )
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org