You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/27 08:28:18 UTC
[GitHub] [incubator-superset] blcksrx opened a new pull request #9924: feat: Excel file export
blcksrx opened a new pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Support excel for exporting
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `4.89%`.
> The diff coverage is `28.91%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.32% -4.90%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
- Hits 21957 20530 -1427
- Misses 8762 10243 +1481
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.19% <21.42%> (-0.21%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.36% <18.91%> (-1.70%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `5.11%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.10% -5.12%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20376 -1581
- Misses 8762 10269 +1507
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `70.84% <20.00%> (-0.56%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `32.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 71.14% -0.09%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
+ Hits 21957 22020 +63
- Misses 8762 8823 +61
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.81% <37.03%> (-0.03%)` | :arrow_down: |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.26% <21.42%> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `53.84% <0.00%> (-2.16%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <ø> (ø)` | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `44.77% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <18.91%> (-1.49%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.94% <25.00%> (-2.70%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.75% <25.00%> (-0.23%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-703188899
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.25% -4.98%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20422 -1535
- Misses 8762 10223 +1461
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.10% <20.00%> (-0.30%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.63% <16.66%> (-2.43%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `4.85%`.
> The diff coverage is `28.91%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.36% -4.86%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
- Hits 21957 20542 -1415
- Misses 8762 10231 +1469
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.26% <21.42%> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <18.91%> (-1.49%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-645554807
@blcksrx - could you share more about this feature use case and why .csv is not good enough? e.g. excel supports csv files as well as I know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `1.45%`.
> The diff coverage is `80.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 69.77% -1.46%
==========================================
Files 585 184 -401
Lines 30828 18257 -12571
Branches 3237 0 -3237
==========================================
- Hits 21957 12738 -9219
+ Misses 8762 5519 -3243
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.77% <80.75%> (-1.64%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `82.89% <ø> (ø)` | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <22.22%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <43.75%> (-4.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/pinot.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bpbm90LnB5) | `67.56% <57.14%> (+9.03%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.99% <66.66%> (-14.99%)` | :arrow_down: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `55.81% <71.42%> (-0.60%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| ... and [435 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] blcksrx closed pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
blcksrx closed pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ninad-casebook commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
ninad-casebook commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-715425410
One additional use-case for Excel over CSV is that datetime formats are not preserved in CSV. If the data being exported contains several datetime columns, then since CSV does not store date formatting this data is lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-647719173
Pulling over a comment from a Slack discussion:
I would say it's worth embracing the growth of additional save/export options with a dropdown menu, e.g.:
```
+------------------------+
| Export Data To... | ▼ |
+------------------------+
| Clipboard |
| CSV |
| Excel |
| Parquet |
| Google Sheet |
+------------------------+
```
... to avoid button proliferation and add a spot for future integrations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `32.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 71.09% -0.14%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
+ Hits 21957 22005 +48
- Misses 8762 8838 +76
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.74% <37.03%> (-0.10%)` | :arrow_down: |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.19% <21.42%> (-0.21%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `53.84% <0.00%> (-2.16%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <ø> (ø)` | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `44.77% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.36% <18.91%> (-1.70%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.94% <25.00%> (-2.70%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.75% <25.00%> (-0.23%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `1.61%`.
> The diff coverage is `80.73%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 69.61% -1.62%
==========================================
Files 585 184 -401
Lines 30828 18247 -12581
Branches 3237 0 -3237
==========================================
- Hits 21957 12702 -9255
+ Misses 8762 5545 -3217
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.61% <80.73%> (-1.80%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `82.89% <ø> (ø)` | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <22.22%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <43.75%> (-5.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/pinot.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bpbm90LnB5) | `67.56% <57.14%> (+9.03%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.99% <66.66%> (-14.99%)` | :arrow_down: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `55.81% <71.42%> (-0.60%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| ... and [446 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `32.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 70.89% -0.33%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
- Hits 21957 21944 -13
- Misses 8762 8893 +131
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.96% <37.03%> (-0.88%)` | :arrow_down: |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.19% <21.42%> (-0.21%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `53.84% <0.00%> (-2.16%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <ø> (ø)` | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `44.77% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.36% <18.91%> (-1.70%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.94% <25.00%> (-2.70%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.75% <25.00%> (-0.23%)` | :arrow_down: |
| ... and [39 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `5.00%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.21% -5.01%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20410 -1547
- Misses 8762 10235 +1473
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.03% <20.00%> (-0.37%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `5.00%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.21% -5.01%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20410 -1547
- Misses 8762 10235 +1473
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.03% <20.00%> (-0.37%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `32.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 71.13% -0.10%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
+ Hits 21957 22017 +60
- Misses 8762 8826 +64
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.74% <37.03%> (-0.10%)` | :arrow_down: |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.26% <21.42%> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `53.84% <0.00%> (-2.16%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <ø> (ø)` | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `44.77% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <18.91%> (-1.49%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.94% <25.00%> (-2.70%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.75% <25.00%> (-0.23%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `5.11%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.10% -5.12%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20376 -1581
- Misses 8762 10269 +1507
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `70.84% <20.00%> (-0.56%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `1.43%`.
> The diff coverage is `80.73%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 69.79% -1.44%
==========================================
Files 585 184 -401
Lines 30828 18247 -12581
Branches 3237 0 -3237
==========================================
- Hits 21957 12735 -9222
+ Misses 8762 5512 -3250
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.79% <80.73%> (-1.61%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/presto\_db.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcHJlc3RvX2RiLnB5) | `82.89% <ø> (ø)` | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <22.22%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <43.75%> (-4.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/pinot.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bpbm90LnB5) | `67.56% <57.14%> (+9.03%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.99% <66.66%> (-14.99%)` | :arrow_down: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `55.81% <71.42%> (-0.60%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| ... and [438 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] blcksrx commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634533065
@villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-642304787
just a general comment - it would be nice to fix CI first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] opus-42 edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
opus-42 edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-703886455
Hello @bkyryliuk. I have provided additional context on why this may be useful
#11162.
Not every user may be CSV-friendly users. Excel Export are easier to handle for those users. For me, this is about Superset being more accessible to generic users.
This feature would be really helpful in production
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] opus-42 commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
opus-42 commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-703886455
Hello @bkyryliuk. I have provided additional context on why this may be useful
#11162.
Not every user may be CSV-friendly users. Excel Export are easier to handle for those users. For me, this is about Superset being more accessible to generic users.
This feature would be really help ful in production
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 70.84% -0.38%
==========================================
Files 585 184 -401
Lines 30828 18060 -12768
Branches 3237 0 -3237
==========================================
- Hits 21957 12795 -9162
+ Misses 8762 5265 -3497
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.84% <20.00%> (-0.56%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.63% <25.00%> (-0.35%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.71% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <100.00%> (-0.09%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...438ab2e](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `5.00%`.
> The diff coverage is `28.04%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 66.21% -5.01%
==========================================
Files 585 585
Lines 30828 30824 -4
Branches 3237 3250 +13
==========================================
- Hits 21957 20410 -1547
- Misses 8762 10235 +1473
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.03% <20.00%> (-0.37%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.06% <ø> (-0.02%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.42% <16.66%> (-2.64%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `32.53%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 70.93% -0.29%
==========================================
Files 585 585
Lines 30828 30952 +124
Branches 3237 3250 +13
==========================================
- Hits 21957 21956 -1
- Misses 8762 8881 +119
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.96% <37.03%> (-0.88%)` | :arrow_down: |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `71.26% <21.42%> (-0.15%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `53.84% <0.00%> (-2.16%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <ø> (ø)` | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `44.77% <0.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.07% <ø> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.57% <18.91%> (-1.49%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.94% <25.00%> (-2.70%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.75% <25.00%> (-0.23%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9924: feat: Excel file export
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9924:
URL: https://github.com/apache/incubator-superset/pull/9924#issuecomment-634514074
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=h1) Report
> Merging [#9924](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edfc8f68dbc6f5c1c996e7c1fe3b84e6561a068&el=desc) will **decrease** coverage by `11.83%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9924 +/- ##
===========================================
- Coverage 71.22% 59.39% -11.84%
===========================================
Files 585 401 -184
Lines 30828 12764 -18064
Branches 3237 3250 +13
===========================================
- Hits 21957 7581 -14376
+ Misses 8762 5004 -3758
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (+0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `81.81% <ø> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `23.07% <0.00%> (-32.93%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.20% <0.00%> (-57.24%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | `90.90% <ø> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <ø> (-68.54%)` | :arrow_down: |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | `34.32% <0.00%> (-10.45%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-22.05%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC5qc3g=) | `70.58% <57.14%> (-1.10%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `77.19% <100.00%> (-5.85%)` | :arrow_down: |
| ... and [327 more](https://codecov.io/gh/apache/incubator-superset/pull/9924/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=footer). Last update [9edfc8f...a116941](https://codecov.io/gh/apache/incubator-superset/pull/9924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org