[GitHub] srkukarni commented on a change in pull request #2807: Source/Sink Endpoint validations

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #2807: Source/Sink Endpoint validations
URL: https://github.com/apache/pulsar/pull/2807#discussion_r226401498
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
 ##########
 @@ -288,43 +293,57 @@ public Response updateFunction(final String tenant, final String namespace, fina
     }
 
     public Response deregisterFunction(final String tenant, final String namespace, final String functionName,
-            String clientRole) {
+            String sourceName, String sinkName, String clientRole) {
 
 Review comment:
   I'll add that as a TODO list to break down even the FunctionImpl into those three categories.
   For now the abstraction is that from a user perspective, sinks/sources/functions are distintive with their own 'namespaces' in some sense. Currently they use the same backend which doesn;t really distinguish, but atleast from the outside world there is some semblance of difference

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services