You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/10/02 07:44:30 UTC

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: https://github.com/apache/incubator-superset/pull/3492#discussion_r142071323
 
 

 ##########
 File path: dev-reqs.txt
 ##########
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   I have added the necessary packages to `setup.py` so that `PandasDatasource` works for csv, html, json and Excel.
   
   @xrmx do you think it would be a good idea to allow `PandasDatasource.FORMATS` to be overridden from settings, much as we allow `ADDITIONAL_MODULE_DS_MAP` to add extra Connectors? Then a specific installation could, for example, install `pytables` and then set:
   
   ```python
   ADDITIONAL_PANDAS_FORMATS = [('hdf', 'HDF5')]
   ```
   
   Another approach would be to attempt to dynamically set the list of allowable formats based on whether we can import the required dependencies.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services