[jira] [Work logged] (TS-4845) NULL dereference in url_sig

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4845?focusedWorklogId=28995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28995 ]

ASF GitHub Bot logged work on TS-4845:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/16 21:11
            Start Date: 13/Sep/16 21:11
    Worklog Time Spent: 10m 
      Work Description: GitHub user jrushford opened a pull request:

    https://github.com/apache/trafficserver/pull/1015

    TS-4845: NULL dereference in url_sig

    Fix a NULL dereference in url_sig.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jrushford/trafficserver TS-4845

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1015
    
----
commit 6b4100c1200e309e229c9fdd24004e1d4fb59c9a
Author: John J. Rushford <jr...@apache.org>
Date:   2016-09-13T21:08:52Z

    TS-4845: NULL dereference in url_sig

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 28995)
            Time Spent: 10m
    Remaining Estimate: 0h

> NULL dereference in url_sig
> ---------------------------
>
>                 Key: TS-4845
>                 URL: https://issues.apache.org/jira/browse/TS-4845
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: James Peach
>            Assignee: John Rushford
>             Fix For: 7.1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Seen in the static analyzer:
> {noformat}
> Making all in url_sig
>   CC       url_sig.lo
> url_sig.c:564:38: warning: Null pointer argument in call to string length function
>   app_qry = getAppQueryString(query, strlen(query));
>                                      ^~~~~~~~~~~~~
> 1 warning generated.
> {noformat}
> If there is no query string you can still do {{goto allow}}, but it looks like the code assumes missing query string will always {{goto deny}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)