You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2019/01/17 18:06:51 UTC
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12230
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
IMPALA-8089: Fixing run-all-tests timeout raciness.
We observed some failures in "pkill -P $TIMEOUT_PID". pkill
will fail if there are no child processes, which could happen
if there is, at that point in time, no "sleep" process running.
To fix this, we simply ignore the error condition here.
I added some debugging to run-all-tests-timeout-check.sh as well.
I'm not 100% certain this is the right fix.
Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
---
M bin/run-all-tests-timeout-check.sh
M bin/run-all-tests.sh
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12230/1
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
IMPALA-8089: Fixing run-all-tests timeout raciness.
We observed some failures in "pkill -P $TIMEOUT_PID". pkill
will fail if there are no child processes, which could happen
if there is, at that point in time, no "sleep" process running.
To fix this, we simply ignore the error condition here.
I added some debugging to run-all-tests-timeout-check.sh as well.
I'm not 100% certain this is the right fix.
Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Reviewed-on: http://gerrit.cloudera.org:8080/12230
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests-timeout-check.sh
M bin/run-all-tests.sh
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 2: Code-Review+2
LGTM. stared at the script for a while and this seems like the most plausible cause.
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Jan 2019 00:23:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 23:50:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3652/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 23:50:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 1: Code-Review+1
Seems a fine place to start. Bikram, thoughts?
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 18:44:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Jan 2019 03:50:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 1: Code-Review+2
I'm self-promoting since this is breaking some builds and is pretty easy. Feel free to -1 this while it's running tests if we want to stop it :)
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 23:49:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8089: Fixing run-all-tests timeout raciness.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12230 )
Change subject: IMPALA-8089: Fixing run-all-tests timeout raciness.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1799/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccfda933f526c116e49c46bf34f7245b357cb07
Gerrit-Change-Number: 12230
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 18:37:33 +0000
Gerrit-HasComments: No