You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/02/07 16:28:13 UTC
[GitHub] [logging-log4j-tools] ppkarwasz opened a new pull request, #30: Normalize line endings
ppkarwasz opened a new pull request, #30:
URL: https://github.com/apache/logging-log4j-tools/pull/30
We want to achieve a higher reproducibility standard on Windows: if a Windows user checks out this repository and compiles a `rel/x.x.x` tag, he should obtain exactly the same JAR files as those published.
Therefore we need to normalize the line endings of all text resources to LF. This closes #29.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-tools] vy commented on pull request #30: Normalize line endings
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #30:
URL: https://github.com/apache/logging-log4j-tools/pull/30#issuecomment-1421295668
@ppkarwasz, I am not familiar with the concept. Hence feel free to merge it. Though the change certainly warrants an entry in `/CHANGELOG.adoc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Normalize line endings (logging-log4j-tools)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #30:
URL: https://github.com/apache/logging-log4j-tools/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j-tools] ppkarwasz commented on pull request #30: Normalize line endings
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #30:
URL: https://github.com/apache/logging-log4j-tools/pull/30#issuecomment-1422329463
This doesn't work as expected, since `flatten-maven-plugin` has these nice lines:
```lang-java
if ( System.getProperty( "os.name" ).contains( "Windows" ) )
{
data = data.replace( "\n", "\r\n" );
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org