You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/13 01:42:06 UTC

[GitHub] [iotdb] zyk990424 opened a new pull request #3544: [IOTDB-1482]Fix timeseries count and device count with Template

zyk990424 opened a new pull request #3544:
URL: https://github.com/apache/iotdb/pull/3544


   ## Description
   
   ### Bug Description
   Apache IoTDB v0.12 cannot count timeseries and device correctly after introducing template.
   
   ### Bug Reproduction
   When we create a template t1(s1, s2) and then set it to device root.sg1.d1, we expect value 2 produced by count timeseries and value 1 produced by count device. However, the actual result is 0 timeseries and 0 device.
   
   ### Bug Fix Solution
   If a MNode is using template, it should be considered as device and the schema in its template will be considered as timeseries. However, the current code only consider a MeasurementMNode as timeseries and a MNode with MeasurementMNode child as device. Therefore, the method getAllTimeseriesCount and getAllTimeseriesCount in MTree.java should be modified and the judging criteria will be extended with template usage.
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are corner cases and error 
       conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, inheritance, composition, 
       design patterns)
    - Method organization and design (how the logic is split between methods, parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative name) for every design 
   (or naming) decision point and compare the alternatives with the designs that you've implemented 
   (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in this PR elsewhere 
   (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), 
   link to that discussion from this PR description and explain what have changed in your final design 
   compared to your original proposal or the consensus version in the end of the discussion. 
   If something hasn't changed since the original discussion, you can omit a detailed discussion of 
   those aspects of the design here, perhaps apart from brief mentioning for the sake of readability 
   of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   -  added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items 
   apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on pull request #3544: [IOTDB-1482]Fix timeseries count and device count with Template

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3544:
URL: https://github.com/apache/iotdb/pull/3544#issuecomment-878713459


   Hi, you can use `mvn spotless:apply` to format the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3544: [IOTDB-1482]Fix timeseries count and device count with Template

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3544:
URL: https://github.com/apache/iotdb/pull/3544#issuecomment-878732784


   
   [![Coverage Status](https://coveralls.io/builds/41313674/badge)](https://coveralls.io/builds/41313674)
   
   Coverage decreased (-0.009%) to 68.164% when pulling **13256eb431ae3df562501a236a0687172cb8c722 on zyk990424:jira_1482_to_master** into **80aa392bb8b26749804103ccabfb793623196035 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] qiaojialin merged pull request #3544: [IOTDB-1482]Fix timeseries count and device count with Template

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3544:
URL: https://github.com/apache/iotdb/pull/3544


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #3544: [IOTDB-1482]Fix timeseries count and device count with Template

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3544:
URL: https://github.com/apache/iotdb/pull/3544#issuecomment-878732784


   
   [![Coverage Status](https://coveralls.io/builds/41313300/badge)](https://coveralls.io/builds/41313300)
   
   Coverage decreased (-0.02%) to 68.152% when pulling **13256eb431ae3df562501a236a0687172cb8c722 on zyk990424:jira_1482_to_master** into **80aa392bb8b26749804103ccabfb793623196035 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org