You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "AlinsRan (via GitHub)" <gi...@apache.org> on 2023/03/01 14:00:36 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1698: docs: update grpc proxy
AlinsRan opened a new pull request, #1698:
URL: https://github.com/apache/apisix-ingress-controller/pull/1698
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [ ] Refactor
- [ ] Chore
- [ ] CI/CD or Tests
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1698: docs: update grpc proxy
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on code in PR #1698:
URL: https://github.com/apache/apisix-ingress-controller/pull/1698#discussion_r1122783990
##########
docs/en/latest/tutorials/proxy-grpc-service.md:
##########
@@ -72,10 +72,9 @@ kubectl run yages -n ingress-apisix --image smirl/yages:0.1.3 --expose --port 90
Use the service that includes `grpcurl` to test gRPC connectivity.
-```bash
-kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=quay.io/mhausenblas/gump:0.1 -- sh
-If you don't see a command prompt, try pressing enter.
-/go $ grpcurl --plaintext yages:9000 yages.Echo.Ping
+```shell
+$ kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=alinsran/grpcurl -- \
Review Comment:
What's the difference between the image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1698: docs: update grpc proxy
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on code in PR #1698:
URL: https://github.com/apache/apisix-ingress-controller/pull/1698#discussion_r1123245802
##########
docs/en/latest/tutorials/proxy-grpc-service.md:
##########
@@ -72,10 +72,9 @@ kubectl run yages -n ingress-apisix --image smirl/yages:0.1.3 --expose --port 90
Use the service that includes `grpcurl` to test gRPC connectivity.
-```bash
-kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=quay.io/mhausenblas/gump:0.1 -- sh
-If you don't see a command prompt, try pressing enter.
-/go $ grpcurl --plaintext yages:9000 yages.Echo.Ping
+```shell
+$ kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=alinsran/grpcurl -- \
Review Comment:
First of all, the original image is no longer maintained and has not been updated for more than five years. When using tls communication, errors will occur. It may be that the protocol content has changed.
I will replace it with the official version 1.8.7, make it work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] navendu-pottekkat merged pull request #1698: docs: update grpc proxy
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat merged PR #1698:
URL: https://github.com/apache/apisix-ingress-controller/pull/1698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1698: docs: update grpc proxy
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on code in PR #1698:
URL: https://github.com/apache/apisix-ingress-controller/pull/1698#discussion_r1123257943
##########
docs/en/latest/tutorials/proxy-grpc-service.md:
##########
@@ -72,10 +72,9 @@ kubectl run yages -n ingress-apisix --image smirl/yages:0.1.3 --expose --port 90
Use the service that includes `grpcurl` to test gRPC connectivity.
-```bash
-kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=quay.io/mhausenblas/gump:0.1 -- sh
-If you don't see a command prompt, try pressing enter.
-/go $ grpcurl --plaintext yages:9000 yages.Echo.Ping
+```shell
+$ kubectl run -it -n ingress-apisix --rm grpcurl --restart=Never --image=alinsran/grpcurl -- \
Review Comment:
make sense. https://github.com/fullstorydev/grpcurl is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org