You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/06/05 12:21:52 UTC
[GitHub] [kafka] yashmayya opened a new pull request, #13810: MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog
yashmayya opened a new pull request, #13810:
URL: https://github.com/apache/kafka/pull/13810
- The `KafkaBasedLog` abstraction is used by Kafka Connect's three metadata topics - offsets, configs, and statuses.
- This generic `KafkaBasedLog` was split off from the `KafkaOffsetBackingStore` [here](https://github.com/apache/kafka/pull/241/files#diff-bd393ce25d7e04ff71f9f5b65bfdc87eac40e378a83cbfc96fd68d227ea07da4) when adding support for the distributed mode in Kafka Connect (specifically for supporting the Kafka topic based config backing store)
- The exception message in question here wasn't refactored to account for the `KafkaBasedLog`'s generic functionality (versus the offsets topic specific logic in the `KafkaOffsetBackingStore`)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #13810: MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13810:
URL: https://github.com/apache/kafka/pull/13810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13810: MINOR: Remove reference to 'offset backing store' from exception message in KafkaBasedLog
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13810:
URL: https://github.com/apache/kafka/pull/13810#issuecomment-1576871102
Similar to https://github.com/apache/kafka/pull/13808#issuecomment-1576833452, I've verified locally that this builds correctly and, given the extremely limited scope of the change, feel comfortable merging without waiting for CI first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org