You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2023/03/23 16:40:15 UTC
[GitHub] [hudi] Zouxxyy opened a new pull request, #8277: [MINOR] Add fs in the constructor of HoodieAvroHFileReader
Zouxxyy opened a new pull request, #8277:
URL: https://github.com/apache/hudi/pull/8277
### Change Logs
for https://github.com/apache/hudi/issues/8257
After hbase 2.4.13, the constructor of `ReaderContext` has changed, and a configuration needs to be fetched through hfs,
But currently hudi will pass hfs as null, which will cause NPE
hbase 2.4.13+:
https://github.com/apache/hbase/blob/90fb1ddc1df9b345f26687d5d24cedfb19621d63/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ReaderContext.java#L53
hbase 2.4.9: (hudi use)
https://github.com/apache/hbase/blob/c49f7f63fca144765bf7c2da41791769286dfccc/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ReaderContext.java#L50
### Impact
Avoid potential risk of NPE caused by upgrading hbase in the future
### Risk level (write none, low medium or high below)
low
### Documentation Update
None
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482497905
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878)
* 57054a7473a885fa639dbb2fa37763a7df04ecc9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892)
* cfc853da93c08d1317c9de4a7c4116ddc89e8344 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1481819938
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482488019
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878)
* 57054a7473a885fa639dbb2fa37763a7df04ecc9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482875309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
}, {
"hash" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfc853da93c08d1317c9de4a7c4116ddc89e8344 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894)
* 8071f3f4a10a0aa0f3e295985aebdc5ed176e31c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #8277:
URL: https://github.com/apache/hudi/pull/8277#discussion_r1147573904
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -168,8 +170,14 @@ protected <T> ClosableIterator<HoodieRecord<T>> deserializeRecords(byte[] conten
// Get schema from the header
Schema writerSchema = new Schema.Parser().parse(super.getLogBlockHeader().get(HeaderMetadataType.SCHEMA));
+ HoodieLogBlockContentLocation blockContentLoc = getBlockContentLocation().get();
+ Configuration inlineConf = new Configuration(blockContentLoc.getHadoopConf());
+ inlineConf.set("fs." + InLineFileSystem.SCHEME + ".impl", InLineFileSystem.class.getName());
+ inlineConf.setClassLoader(InLineFileSystem.class.getClassLoader());
+
+ FileSystem fs = FSUtils.getFs(pathForReader.toString(), inlineConf);
Review Comment:
Sounds good @Zouxxyy , as along as we are ok with compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1492820564
> Hi @Zouxxyy HBase dependencies are shaded in Hudi so Hudi always uses the shaded version based on HBase 2.4.9. Could you clarify why Hbase 2.4.13+ fails Hudi in this case?
In https://github.com/apache/hudi/issues/8257, user manually modified the version of hbase, and then compiled his own package
<img width="393" alt="image" src="https://user-images.githubusercontent.com/37108074/229264557-c43fcb6d-bbaf-4699-84c2-68804f2348d2.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #8277:
URL: https://github.com/apache/hudi/pull/8277#discussion_r1147272883
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -168,8 +170,14 @@ protected <T> ClosableIterator<HoodieRecord<T>> deserializeRecords(byte[] conten
// Get schema from the header
Schema writerSchema = new Schema.Parser().parse(super.getLogBlockHeader().get(HeaderMetadataType.SCHEMA));
+ HoodieLogBlockContentLocation blockContentLoc = getBlockContentLocation().get();
+ Configuration inlineConf = new Configuration(blockContentLoc.getHadoopConf());
+ inlineConf.set("fs." + InLineFileSystem.SCHEME + ".impl", InLineFileSystem.class.getName());
+ inlineConf.setClassLoader(InLineFileSystem.class.getClassLoader());
+
+ FileSystem fs = FSUtils.getFs(pathForReader.toString(), inlineConf);
Review Comment:
@danny0405 Thanks, I create a common method `buildInlineConf()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1481586400
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8277:
URL: https://github.com/apache/hudi/pull/8277#discussion_r1147066368
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -168,8 +170,14 @@ protected <T> ClosableIterator<HoodieRecord<T>> deserializeRecords(byte[] conten
// Get schema from the header
Schema writerSchema = new Schema.Parser().parse(super.getLogBlockHeader().get(HeaderMetadataType.SCHEMA));
+ HoodieLogBlockContentLocation blockContentLoc = getBlockContentLocation().get();
+ Configuration inlineConf = new Configuration(blockContentLoc.getHadoopConf());
+ inlineConf.set("fs." + InLineFileSystem.SCHEME + ".impl", InLineFileSystem.class.getName());
+ inlineConf.setClassLoader(InLineFileSystem.class.getClassLoader());
+
+ FileSystem fs = FSUtils.getFs(pathForReader.toString(), inlineConf);
Review Comment:
In `#lookupRecords`, there is similar logic for generating the fs, can we abstract the code snippet into a common utitlies method like `#getFs` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #8277:
URL: https://github.com/apache/hudi/pull/8277#discussion_r1146494242
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -168,8 +170,14 @@ protected <T> ClosableIterator<HoodieRecord<T>> deserializeRecords(byte[] conten
// Get schema from the header
Schema writerSchema = new Schema.Parser().parse(super.getLogBlockHeader().get(HeaderMetadataType.SCHEMA));
+ HoodieLogBlockContentLocation blockContentLoc = getBlockContentLocation().get();
+ Configuration inlineConf = new Configuration(blockContentLoc.getHadoopConf());
+ inlineConf.set("fs." + InLineFileSystem.SCHEME + ".impl", InLineFileSystem.class.getName());
+ inlineConf.setClassLoader(InLineFileSystem.class.getClassLoader());
+
+ FileSystem fs = FSUtils.getFs(pathForReader.toString(), inlineConf);
Review Comment:
Should we guard this in HBase version check? Intention is to avoid additional call if fs is not needed in some hbase version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1481573275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482770134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfc853da93c08d1317c9de4a7c4116ddc89e8344 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #8277:
URL: https://github.com/apache/hudi/pull/8277#discussion_r1147036589
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -168,8 +170,14 @@ protected <T> ClosableIterator<HoodieRecord<T>> deserializeRecords(byte[] conten
// Get schema from the header
Schema writerSchema = new Schema.Parser().parse(super.getLogBlockHeader().get(HeaderMetadataType.SCHEMA));
+ HoodieLogBlockContentLocation blockContentLoc = getBlockContentLocation().get();
+ Configuration inlineConf = new Configuration(blockContentLoc.getHadoopConf());
+ inlineConf.set("fs." + InLineFileSystem.SCHEME + ".impl", InLineFileSystem.class.getName());
+ inlineConf.setClassLoader(InLineFileSystem.class.getClassLoader());
+
+ FileSystem fs = FSUtils.getFs(pathForReader.toString(), inlineConf);
Review Comment:
@codope I think its call time is actually very small, and I haven't seen the usage of setting fs to null elsewhere, which is a bit confusing.
Of course, I can also add the version as a condition, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482478020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f48a5ab4c17103cbd01f655d343adfab56c7655 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878)
* 57054a7473a885fa639dbb2fa37763a7df04ecc9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482889660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
}, {
"hash" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15900",
"triggerID" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cfc853da93c08d1317c9de4a7c4116ddc89e8344 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894)
* 8071f3f4a10a0aa0f3e295985aebdc5ed176e31c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15900)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1492432225
Hi @Zouxxyy HBase dependencies are shaded in Hudi so Hudi always uses the shaded version based on HBase 2.4.9. Could you clarify why Hbase 2.4.13+ fails Hudi in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482550412
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57054a7473a885fa639dbb2fa37763a7df04ecc9 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892)
* cfc853da93c08d1317c9de4a7c4116ddc89e8344 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1482799152
> @Zouxxyy Looks like there is a checkstyle violation. Can you please correct? https://github.com/apache/hudi/actions/runs/4509620758/jobs/7944047354?pr=8277
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1483241834
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15878",
"triggerID" : "7f48a5ab4c17103cbd01f655d343adfab56c7655",
"triggerType" : "PUSH"
}, {
"hash" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15892",
"triggerID" : "57054a7473a885fa639dbb2fa37763a7df04ecc9",
"triggerType" : "PUSH"
}, {
"hash" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15894",
"triggerID" : "cfc853da93c08d1317c9de4a7c4116ddc89e8344",
"triggerType" : "PUSH"
}, {
"hash" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15900",
"triggerID" : "8071f3f4a10a0aa0f3e295985aebdc5ed176e31c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8071f3f4a10a0aa0f3e295985aebdc5ed176e31c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15900)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #8277:
URL: https://github.com/apache/hudi/pull/8277#issuecomment-1487156207
@codope hi, CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #8277: [HUDI-5976] Add fs in the constructor of HoodieAvroHFileReader
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #8277:
URL: https://github.com/apache/hudi/pull/8277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org