You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/05/12 22:22:58 UTC
Review Request 59233: Updated v6 address for containers running on
host network.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs
-----
src/slave/slave.cpp 209aff180db1a68ae360d7c278937fe645efdb2b
Diff: https://reviews.apache.org/r/59233/diff/1/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/#review174888
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59127, 59128, 59129, 59130, 59131, 59233]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 12, 2017, 10:22 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59233/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 10:22 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently the agent is populating only the v4 address for containers
> running on the host network. However, clusters running on a dual stack
> network need to report v4 and v6 address for containers running on the
> host network. This change allows v6 address specified by operators to be
> advertised for containers running on the host network.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 209aff180db1a68ae360d7c278937fe645efdb2b
>
>
> Diff: https://reviews.apache.org/r/59233/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/#review176515
-----------------------------------------------------------
Bad patch!
Reviews applied: [59233, 59131, 59130, 59129, 59688, 59128, 59127]
Failed command: python support/apply-reviews.py -n -r 59127
Error:
error: patch failed: 3rdparty/CMakeLists.txt:282
error: 3rdparty/CMakeLists.txt: patch does not apply
error: patch failed: 3rdparty/cmake/Versions.cmake:1
error: 3rdparty/cmake/Versions.cmake: patch does not apply
error: patch failed: CHANGELOG:192
error: CHANGELOG: patch does not apply
error: patch failed: cmake/CompilationConfigure.cmake:228
error: cmake/CompilationConfigure.cmake: patch does not apply
error: patch failed: src/slave/main.cpp:450
error: src/slave/main.cpp: patch does not apply
error: patch failed: src/tests/CMakeLists.txt:193
error: src/tests/CMakeLists.txt: patch does not apply
error: patch failed: src/tests/containerizer/environment_secret_isolator_tests.cpp:1
error: src/tests/containerizer/environment_secret_isolator_tests.cpp: patch does not apply
error: patch failed: src/tests/containerizer/volume_secret_isolator_tests.cpp:1
error: src/tests/containerizer/volume_secret_isolator_tests.cpp: patch does not apply
error: patch failed: src/tests/containerizer/xfs_quota_tests.cpp:590
error: src/tests/containerizer/xfs_quota_tests.cpp: patch does not apply
error: patch failed: src/uri/fetchers/docker.cpp:527
error: src/uri/fetchers/docker.cpp: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/console
- Mesos Reviewbot Windows
On May 31, 2017, 6:38 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59233/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 6:38 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently the agent is populating only the v4 address for containers
> running on the host network. However, clusters running on a dual stack
> network need to report v4 and v6 address for containers running on the
> host network. This change allows v6 address specified by operators to be
> advertised for containers running on the host network.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 209aff180db1a68ae360d7c278937fe645efdb2b
>
>
> Diff: https://reviews.apache.org/r/59233/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated July 6, 2017, 11:36 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed BenH's comments.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8
include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02
src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
Diff: https://reviews.apache.org/r/59233/diff/7/
Changes: https://reviews.apache.org/r/59233/diff/6-7/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/#review179691
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp
Lines 4543 (patched)
<https://reviews.apache.org/r/59233/#comment254506>
s/Setup/Set up/
src/slave/slave.cpp
Lines 4545 (patched)
<https://reviews.apache.org/r/59233/#comment254507>
... the protocol is set to `IPv4` and therefore we don't explicitly set the protocol here.
- Benjamin Hindman
On June 29, 2017, 11:22 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59233/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 11:22 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently the agent is populating only the v4 address for containers
> running on the host network. However, clusters running on a dual stack
> network need to report v4 and v6 address for containers running on the
> host network. This change allows v6 address specified by operators to be
> advertised for containers running on the host network.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4
> include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b
> src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199
>
>
> Diff: https://reviews.apache.org/r/59233/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated June 29, 2017, 11:22 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4
include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b
src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199
Diff: https://reviews.apache.org/r/59233/diff/6/
Changes: https://reviews.apache.org/r/59233/diff/5-6/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated June 29, 2017, 11:16 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
include/mesos/mesos.proto 3338349c399c9fb5b7fb2fc5886fb492ffb944c4
include/mesos/v1/mesos.proto 6f0ad71260c36a9cb401c716e02c561580fb433b
src/slave/slave.cpp 1f7aed48eb3ab3ee2a797d4061a6e289852b8199
Diff: https://reviews.apache.org/r/59233/diff/5/
Changes: https://reviews.apache.org/r/59233/diff/4-5/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated June 16, 2017, 4:36 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
include/mesos/mesos.proto e9a8b1513150b394f4986a1f34483cfca32b35e3
include/mesos/v1/mesos.proto 5e8c15c07a02999e3376d2104c1c642f00511969
src/slave/slave.cpp 91a1bf330c3d5e91ef1b5ed016f9b3d0ad78400f
Diff: https://reviews.apache.org/r/59233/diff/4/
Changes: https://reviews.apache.org/r/59233/diff/3-4/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated June 16, 2017, 3:54 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased and addressed BenH's comments
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
include/mesos/mesos.proto e9a8b1513150b394f4986a1f34483cfca32b35e3
include/mesos/v1/mesos.proto 5e8c15c07a02999e3376d2104c1c642f00511969
src/slave/slave.cpp 91a1bf330c3d5e91ef1b5ed016f9b3d0ad78400f
Diff: https://reviews.apache.org/r/59233/diff/3/
Changes: https://reviews.apache.org/r/59233/diff/2-3/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/
-----------------------------------------------------------
(Updated May 31, 2017, 6:38 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488
Repository: mesos
Description
-------
Currently the agent is populating only the v4 address for containers
running on the host network. However, clusters running on a dual stack
network need to report v4 and v6 address for containers running on the
host network. This change allows v6 address specified by operators to be
advertised for containers running on the host network.
Diffs (updated)
-----
src/slave/slave.cpp 209aff180db1a68ae360d7c278937fe645efdb2b
Diff: https://reviews.apache.org/r/59233/diff/2/
Changes: https://reviews.apache.org/r/59233/diff/1-2/
Testing
-------
make check
Thanks,
Avinash sridharan
Re: Review Request 59233: Updated v6 address for containers running
on host network.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59233/#review176161
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp
Lines 4424 (patched)
<https://reviews.apache.org/r/59233/#comment249514>
Not that I'm opposed to you setting this explicitly can we also make this the default so that we don't have to have funky if checking code other places where we want to determine if it's v4 or v6?
- Benjamin Hindman
On May 12, 2017, 10:22 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59233/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 10:22 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently the agent is populating only the v4 address for containers
> running on the host network. However, clusters running on a dual stack
> network need to report v4 and v6 address for containers running on the
> host network. This change allows v6 address specified by operators to be
> advertised for containers running on the host network.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 209aff180db1a68ae360d7c278937fe645efdb2b
>
>
> Diff: https://reviews.apache.org/r/59233/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Avinash sridharan
>
>