You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Florian Hockmann (Jira)" <ji...@apache.org> on 2020/11/11 14:55:00 UTC
[jira] [Closed] (TINKERPOP-2253) Special case for JToken in
SubmitAsync()
[ https://issues.apache.org/jira/browse/TINKERPOP-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Hockmann closed TINKERPOP-2253.
---------------------------------------
Resolution: Won't Fix
I'm closing this now as this has only affected the downstream library {{Gremlin.Net.CosmosDb}} by {{evo-terren}} who [has abandoned the project completely|https://github.com/evo-terren/Gremlin.Net.CosmosDb#gremlinnetcosmosdb] so it isn't maintained any more. and because we had the behavior now since 3.3.5 / 3.4.0 without any user mentioning that they are also affected by this who are not using that library.
If someone can give a valid use case that got broken by TINKERPOP-2067, then we can reopen this.
> Special case for JToken in SubmitAsync()
> ----------------------------------------
>
> Key: TINKERPOP-2253
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2253
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
> Affects Versions: 3.4.0
> Reporter: Sam Hard
> Priority: Major
>
> A recent change to Gremlin.Net, made to address TINKERPOP-2067, broke existing functionality for the downstream library Gremlin.Net.CosmosDb. That library invokes Gremlin.Net.Driver.Connection's `SubmitAsync<T>()` method, sending `JToken` as the generic type argument, and expects the query results to be run through `_graphSONReader.ToObject()`, but that step is now specifically skipped just for `JToken`.
> I propose that it would be better for Connection.SubmitAsync() to work the same for all types, as it did before, and that a new property in the class (or an optional method parameter) could be used to configure when the graphSON reader should be bypassed.
> The breaking change was merged with this pull request: [https://github.com/apache/tinkerpop/pull/972]
> As a cross-reference, the GitHub issue documenting the problem with Gremlin.Net.CosmosDb can be found here: [https://github.com/evo-terren/Gremlin.Net.CosmosDb/issues/49]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)