You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2024/09/26 02:30:49 UTC
[PR] feat: disconnect observer for web vitals [skywalking-client-js]
Fine0830 opened a new pull request, #142:
URL: https://github.com/apache/skywalking-client-js/pull/142
Screenshot
<img width="494" alt="1" src="https://github.com/user-attachments/assets/143872eb-a12e-4d6e-9791-145fcdfff6d3">
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observers and add new URLs to report for web vitals [skywalking-client-js]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#issuecomment-2378484314
> So, e2e should be as same as previous one, right? We just need to support new URIs.
Right. Please recheck this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observers and add new URLs to report for web vitals [skywalking-client-js]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#discussion_r1777976203
##########
README.md:
##########
@@ -52,7 +52,7 @@ The register method supports the following parameters.
|jsErrors|Boolean|Support js errors monitoring|false|true|
|apiErrors|Boolean|Support API errors monitoring|false|true|
|resourceErrors|Boolean|Support resource errors monitoring|false|true|
-|useFmp|Boolean|Collect FMP (first meaningful paint) data of the first screen|false|false|
+|useFmp|Boolean|Collect FMP (first meaningful paint) data of the first screen. Deprecated: This is no longer recommended. Please use the useWebVitals instead. |false|false|
Review Comment:
Does this affect the OAP analysis and metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observers and add new URLs to report for web vitals [skywalking-client-js]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observers and add new URLs to report for web vitals [skywalking-client-js]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#issuecomment-2378449412
So, e2e should be as same as previous one, right? We just need to support new URIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observers and add new URLs to report for web vitals [skywalking-client-js]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on code in PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#discussion_r1778019356
##########
README.md:
##########
@@ -52,7 +52,7 @@ The register method supports the following parameters.
|jsErrors|Boolean|Support js errors monitoring|false|true|
|apiErrors|Boolean|Support API errors monitoring|false|true|
|resourceErrors|Boolean|Support resource errors monitoring|false|true|
-|useFmp|Boolean|Collect FMP (first meaningful paint) data of the first screen|false|false|
+|useFmp|Boolean|Collect FMP (first meaningful paint) data of the first screen. Deprecated: This is no longer recommended. Please use the useWebVitals instead. |false|false|
Review Comment:
Yes, I moved the FMP metric from` /browser/perfData` to`/browser/perfData/webVitals`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observer for web vitals [skywalking-client-js]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#issuecomment-2378296936
Since I batched reporting performance metrics, the percentile metrics have been affected. I have provisionally removed those two percentile metrics in the test until the backend is adapted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observer for web vitals [skywalking-client-js]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#issuecomment-2375661801
Could you share more context about what does this mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disconnect observer for web vitals [skywalking-client-js]
Posted by "Fine0830 (via GitHub)" <gi...@apache.org>.
Fine0830 commented on PR #142:
URL: https://github.com/apache/skywalking-client-js/pull/142#issuecomment-2375745819
> Could you share more context about what does this mean?
Sure. After the agent obtains relevant data, disconnect all observers
and stop the `MutationObserver` instance from receiving further notifications until `observe()` is called again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org