You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "neilcsmith-net (via GitHub)" <gi...@apache.org> on 2023/03/16 10:58:22 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #5668: Fixes for Java module graph (GH4227)
neilcsmith-net opened a new pull request, #5668:
URL: https://github.com/apache/netbeans/pull/5668
Fixes #4227 - Java module graph component failing to display with a NPE. This is caused by the same issue as fixed in #4780 whereby the module tree is no longer available from `cc.getCompilationUnit().getTypeDecls()` and should be obtained by `cc.getCompilationUnit().getModule()`. Need to look across the code base for other instances of this problem.
Second commit fixes a stack overflow noticed in the search function on the graph. This seems to be due to circular dependencies being reported in the underlying dependency graph - probably some other issues to look at there, but at least it doesn't blow up for now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #5668: Fixes for Java module graph (GH4227)
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #5668:
URL: https://github.com/apache/netbeans/pull/5668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5668: Fixes for Java module graph (GH4227)
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5668:
URL: https://github.com/apache/netbeans/pull/5668#issuecomment-1473590246
Thanks @mbien Hadn't noticed that NPE with readability - wasn't an issue with the project I was testing the graph with, but have replicated on another one. This is a useful graph but could do with some additional work for sure. The JDK module filtering also doesn't seem to work correctly. Will merge this so the graph works at all, then we can work out what else needs fixing! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5668: Fixes for Java module graph (GH4227)
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5668:
URL: https://github.com/apache/netbeans/pull/5668#issuecomment-1472876142
TIL that NB has a module graph for the java module system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5668: Fixes for Java module graph (GH4227)
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5668:
URL: https://github.com/apache/netbeans/pull/5668#issuecomment-1473063946
while clicking around I found a NPE, however this isn't caused by this PR (click on the "Show Readability" icon on the right)
```
java.lang.NullPointerException: Cannot invoke "org.netbeans.api.visual.widget.LabelWidget.setForeground(java.awt.Color)" because "this.versionW" is null
at org.netbeans.modules.java.graph.NodeWidget.updatePaintContent(NodeWidget.java:283)
at org.netbeans.modules.java.graph.DependencyGraphScene.lambda$updateVisibility$1(DependencyGraphScene.java:438)
at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1715)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at org.netbeans.modules.java.graph.DependencyGraphScene.updateVisibility(DependencyGraphScene.java:438)
at org.netbeans.modules.java.module.graph.GraphTopComponent.transitiveCheckBoxActionPerformed(GraphTopComponent.java:376)
at org.netbeans.modules.java.module.graph.GraphTopComponent.access$700(GraphTopComponent.java:76)
at org.netbeans.modules.java.module.graph.GraphTopComponent$7.actionPerformed(GraphTopComponent.java:334)
at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
....
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744)
at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136)
[catch] at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists