You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/10/03 12:13:23 UTC
[jira] Created: (LUCENE-1944) Remove deprecated Directory stuff and
IR/IW open/ctor hell
Remove deprecated Directory stuff and IR/IW open/ctor hell
----------------------------------------------------------
Key: LUCENE-1944
URL: https://issues.apache.org/jira/browse/LUCENE-1944
Project: Lucene - Java
Issue Type: Task
Components: Index, Search, Store
Affects Versions: 2.9
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 3.0
This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
RE: [jira] Commented: (LUCENE-1944) Remove deprecated Directory stuff and IR/IW open/ctor hell
Posted by Uwe Schindler <uw...@thetaphi.de>.
Krr, wrong issue.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Uwe Schindler (JIRA) [mailto:jira@apache.org]
> Sent: Saturday, October 03, 2009 1:26 PM
> To: java-dev@lucene.apache.org
> Subject: [jira] Commented: (LUCENE-1944) Remove deprecated Directory stuff
> and IR/IW open/ctor hell
>
>
> [ https://issues.apache.org/jira/browse/LUCENE-
> 1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=12761858#action_12761858 ]
>
> Uwe Schindler commented on LUCENE-1944:
> ---------------------------------------
>
> Lets add a changes.txt entry in contrib about a BW break.
>
> > Remove deprecated Directory stuff and IR/IW open/ctor hell
> > ----------------------------------------------------------
> >
> > Key: LUCENE-1944
> > URL: https://issues.apache.org/jira/browse/LUCENE-1944
> > Project: Lucene - Java
> > Issue Type: Task
> > Components: Index, Search, Store
> > Affects Versions: 2.9
> > Reporter: Uwe Schindler
> > Assignee: Uwe Schindler
> > Fix For: 3.0
> >
> > Attachments: LUCENE-1944.patch
> >
> >
> > This patch removes primarily the deprecated Directory stuff. This also
> removes parts of the ctor/open hell in IR and IW. IndexModifier is
> completely removed as deprecated, too.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1944) Remove deprecated Directory stuff and
IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1944:
----------------------------------
Attachment: LUCENE-1944.patch
A first version, some tests may use old API, which therefore not compile.
This is a very tricky pert, because you can do lots of errors. Things from 2.9 which were not 100% correct:
- CompoundFileReader.list() was there (deprec), but no listAll(). Renamed function. Does listAll/list difference has any effect in CFR?
- There was one class to list() in SegmentInfos, replaced by listAll()
This patch also makes FSDir abstract and removes all deprecated methods and also the hell of reflection and the system properties.
Patch still needs fine-tuning and test adaption.
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1944) Remove deprecated Directory stuff and
IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1944:
----------------------------------
Comment: was deleted
(was: Lets add a changes.txt entry in contrib about a BW break.)
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1944) Remove deprecated Directory stuff
and IR/IW open/ctor hell
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761850#action_12761850 ]
Michael McCandless commented on LUCENE-1944:
--------------------------------------------
bq. Does listAll/list difference has any effect in CFR?
This should be fine; we don't normally put non-index files into a CFS.
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1944) Remove deprecated Directory stuff and
IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1944:
----------------------------------
Attachment: LUCENE-1944.patch
Updated patch, works with current trunk and backwards branch (after tag was added, not yet done). The previous poatch had some errors because of init() methods and previous closeDir parameter (wrong method was called in some cases)
Contrib tests not yet functional, but test-core works.
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944.patch, LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1944) Remove deprecated Directory stuff
and IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761971#action_12761971 ]
Uwe Schindler commented on LUCENE-1944:
---------------------------------------
I think, I have to commit this now. The current tests in trunk do not compile, as there is now a problem with abstract methods in the MockFSDirectory and FaultyFSDirectory (I was too fast in modifying them and tested only with my changes from this patch).
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944-contrib-fixes.patch, LUCENE-1944.patch, LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1944) Remove deprecated Directory stuff
and IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-1944.
-----------------------------------
Resolution: Fixed
Committed revision: 821446
If there are any problems caused by this, let me know!
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944-contrib-fixes.patch, LUCENE-1944.patch, LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1944) Remove deprecated Directory stuff
and IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761858#action_12761858 ]
Uwe Schindler commented on LUCENE-1944:
---------------------------------------
Lets add a changes.txt entry in contrib about a BW break.
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1944) Remove deprecated Directory stuff and
IR/IW open/ctor hell
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1944:
----------------------------------
Attachment: LUCENE-1944-contrib-fixes.patch
Here are the fixes for contrib to not use the deprecated IndexReader/IndexWriter/FSDir/IndexSearcher methods/ctors.
Now this issue is ready for the final commit.
It would be good, if somebody other would again look over the original patch.
> Remove deprecated Directory stuff and IR/IW open/ctor hell
> ----------------------------------------------------------
>
> Key: LUCENE-1944
> URL: https://issues.apache.org/jira/browse/LUCENE-1944
> Project: Lucene - Java
> Issue Type: Task
> Components: Index, Search, Store
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1944-contrib-fixes.patch, LUCENE-1944.patch, LUCENE-1944.patch
>
>
> This patch removes primarily the deprecated Directory stuff. This also removes parts of the ctor/open hell in IR and IW. IndexModifier is completely removed as deprecated, too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org