[GitHub] [flink] aljoscha commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

[GitBox <gi...@apache.org>]

aljoscha commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink 
URL: https://github.com/apache/flink/pull/9581#issuecomment-533125126
 
 
   This PR seems very contentious because it makes the code of the sink somewhat more complicated.
   
   Taking a step back, could we look at alternative options? You mentioned that the reason for extending this is that you want to extend metrics support. Would a metrics extension point help here, i.e. we add a `MetricsExtension` (name TBD) that we can provide to the `StreamingFileSink` and that is invoked at certain points and the implementation can spit out extended metrics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services