You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/12 20:24:36 UTC
[GitHub] [calcite] jamesstarr opened a new pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
jamesstarr opened a new pull request #2108:
URL: https://github.com/apache/calcite/pull/2108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#issuecomment-679453129
> If there are no objections, could I get this merged.
I think we could, would merge it soon ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] jamesstarr commented on pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
jamesstarr commented on pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#issuecomment-683832232
@danny0405 is this going to get merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] jamesstarr commented on pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
jamesstarr commented on pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#issuecomment-679407490
If there are no objections, could I get this merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] jamesstarr commented on pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
jamesstarr commented on pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#issuecomment-684969510
Ah, Thank you. I will be sure to check main next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on a change in pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#discussion_r475035866
##########
File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -4007,6 +4006,7 @@ protected void validateGroupClause(SqlSelect select) {
}
groupList = new SqlNodeList(expandedList, groupList.getParserPosition());
select.setGroupBy(groupList);
+ inferUnknownTypes(unknownType, groupScope, groupList);
for (SqlNode groupItem : expandedList) {
Review comment:
Seems reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 closed pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
danny0405 closed pull request #2108:
URL: https://github.com/apache/calcite/pull/2108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 commented on pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#issuecomment-684176053
@jamesstarr Already merged in https://github.com/apache/calcite/commit/468b111b3cae44efd31e60c4bafe0018c8821e9a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org