[GitHub] [airflow] BasPH commented on pull request #24733: Add support for multiple cron expressions in schedule_interval

[GitBox <gi...@apache.org>]

BasPH commented on PR #24733:
URL: https://github.com/apache/airflow/pull/24733#issuecomment-1170064157

   > My only question is is it worth exposing this via schedule_interval or should we make people use a timetable directly for this?
   
   I believe it's more convenient exposing it via `schedule_interval` since (1) that's currently how other timetables are exposed and (2) timetables to me feel like an implementation detail with lots of intricate details. I believe multiple crons is a common ask and therefore not worth requiring the user to initialize a timetable.
   
   > Do we also need a new timetable class, or could the existing CornDataIntervalTimetable be extended to take multiple patterns, and then all we change is what gets passed when upgrading schedule_interval.?
   
   We could extend the existing implementation to take a list of cron expressions (and convert a single string to a list of strings internally to align the business logic).
   
   > You also haven't provided a description field (which is IIRC what is shown in the UI) for the new timetable class.
   
   Added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org