You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/26 10:18:13 UTC

[GitHub] [flink] NicoK commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

NicoK commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r297586972
 
 

 ##########
 File path: flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
 ##########
 @@ -66,7 +66,7 @@
 
 	@Test
 	public void testReporterRegistration() throws Exception {
-		MetricRegistryImpl metricRegistry = createMetricRegistry();
+		MetricRegistryImpl metricRegistry = createMetricRegistry("");
 
 Review comment:
   use `RETENTION_POLICY.defaultValue()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services