[GitHub] [incubator-superset] rusackas commented on pull request #10105: fix: Loading overlay bugfix and cleanup

[GitBox <gi...@apache.org>]

rusackas commented on pull request #10105:
URL: https://github.com/apache/incubator-superset/pull/10105#issuecomment-647924545


   @etr2460 This PR is like pulling a loose thread on a sweater... I simplified a few more things, by consolidating some global LESS into the component, and removing the className in favor of additional "position" options. I hope this all makes sense. It seems simpler to me, anyway. I _think_ the only recognizable visual diff is that the "inline" style is 10px narrower, which looks better to my eye, in the one place it's used:
   
   <img width="624" alt="Screenshot_2020-06-22_22_51_01" src="https://user-images.githubusercontent.com/812905/85365836-fb49a800-b4da-11ea-8bed-763b6915bbf1.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org