[GitHub] [incubator-pagespeed-mod] jmarantz commented on issue #2067: Image dimensions are erroneously supplied to amp-img>img elements

[GitBox <gi...@apache.org>]

jmarantz commented on issue #2067:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2067#issuecomment-840091755


   The easiest approach may be to disable the insert_image_dimensions
   <https://www.modpagespeed.com/doc/reference-image-optimize#insert_image_dimensions>
    filter:
   
   ModPagespeedDisableFilters insert_image_dimensions
   
   you can also do this in an amp-specific way using fancier config-file
   constructs (the syntax of which I have now forgotten :), but it's easiest
   if AMP pages are under an "/amp/" subdirectory in the URL path.
   
   -Josh
   
   
   
   On Wed, May 12, 2021 at 2:49 PM Lofesa ***@***.***> wrote:
   
   > Hi @westonruter <https://github.com/westonruter>
   > As far as I know only the filters resize_images and
   > resize_rendered_image_dimensions can be related to this issue.
   > Pagespeed by default has a rewrite level core
   > <https://www.modpagespeed.com/doc/config_filters#level> that enables the
   > resize_images.
   >
   > There are some ways to disable these filters:
   >
   > pagespeed DisableFilters filtera,filterb; (nginx)
   >
   > ModPagespeedDisableFilters filtera,filterb (apache)
   >
   >
   > But these disables the filters for all request, not only for amp pages.
   > Maybe some type of logic can disable these filters only for amp request.
   > If I remember the AMP Plugin put amp as an arg to the url, so some like
   > this may work:
   >
   > if ($args = amp) {
   >
   >              set $disable_filters "resize_images,resize_rendered_image_dimensions";
   >
   >       }
   >
   >
   >
   >  pagespeed DisableFilters "$disable_filters";
   >
   >
   >
   >
   > That´s nginx syntax, I don´t know if in apache can be done.
   >
   > pagespeed UrlValuedAttribute amp-img src image
   >
   > in their config
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pagespeed-mod/issues/2067#issuecomment-840017441>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAO2IPKQIGGIEPFNVHCGCADTNLESRANCNFSM44X4ILYA>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org