You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ilya Suntsov (JIRA)" <ji...@apache.org> on 2019/05/14 12:49:00 UTC

[jira] [Comment Edited] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify

    [ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839383#comment-16839383 ] 

Ilya Suntsov edited comment on IGNITE-10896 at 5/14/19 12:48 PM:
-----------------------------------------------------------------

[~Denis Chudov] I've checked the fix.

I've tried to pass as parameter regexp that doesn't match any node's cache.

 {noformat}

bin/control.sh --cache idle_verify cachepoc1.* --cache-filter PERSISTENT --host 172.25.1.29

Control utility [ver. 2.5.8#20190511-sha1:8b27f3a6]

2019 Copyright(C) Apache Software Foundation

User: isuntsov

Time: 2019-05-14T15:22:20.565

--------------------------------------------------------------------------------

idle_verify failed.There are no caches matching given filter options.Idle verify failed on nodes:

Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29] consistent ID: poc-tester-server-172.25.1.29-id-0

See log for additional information. /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt

{noformat}

The message is CORRECT but I think that text formatting doesn't look well.

I guess should be:

{noformat}

--------------------------------------------------------------------------------

idle_verify failed.

There are no caches matching given filter options: [ cachepoc1.*; PERSISTENT].

Idle verify failed on nodes:

Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29]

Consistent ID: poc-tester-server-172.25.1.29-id-0

See log for additional information: /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt

{noformat}

 


was (Author: ustas):
[~Denis Chudov] I've checked the fix.

I've tried to pass as parameter regexp that doesn't match any node's cache.

 \{noformat}

bin/control.sh --cache idle_verify cachepoc1.* --cache-filter PERSISTENT --host 172.25.1.29

Control utility [ver. 2.5.8#20190511-sha1:8b27f3a6]

2019 Copyright(C) Apache Software Foundation

User: isuntsov

Time: 2019-05-14T15:22:20.565

--------------------------------------------------------------------------------

idle_verify failed.There are no caches matching given filter options.Idle verify failed on nodes:

Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29] consistent ID: poc-tester-server-172.25.1.29-id-0

See log for additional information. /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt

{noformat}

The message is CORRECT but I think that text formatting doesn't look well.

I guess should be:

{noformat}

--------------------------------------------------------------------------------

idle_verify failed.

There are no caches matching given filter options: [ cachepoc1.*; PERSISTENT].

Idle verify failed on nodes:

Node ID: e5a981f6-9d0b-4cd7-aad3-fe3cc7fa6101 [172.25.1.29]

Consistent ID: poc-tester-server-172.25.1.29-id-0

See log for additional information: /home/isuntsov/858_test/idle_verify-2019-05-14T15-22-20_895.txt

{noformat}

 

> Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
> -------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10896
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: ARomantsov
>            Assignee: Denis Chudov
>            Priority: Major
>             Fix For: 2.8
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Now I can use only one of next options
> 1) --exclude-caches cache1,...,cacheN
> 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT
> 3) cache1,...,cacheN
> Trying to use two or more of this options currently results in error:
> {noformat}
> Error: Should use only one of option: --excludeCaches, --cache-filter or pass caches explicitly
> {noformat}
> Instead, utility should do the following:
>  1) when two or more options specified, result cache set to make dump of should be logical AND of results of each option applied individually.
>      ex. 
> {noformat}
>      cache.* --cache-filter PERSISTENT
> {noformat}
> should select all persistent caches starting from 'cache'
> {noformat}
>    --cache-filter ALL
>    --exclude-caches wrong-.*-caches
> {noformat}
> should select all caches but matching 'wrong-.*-caches' regexp
>  etc.
>  2) filtering options passed to control utility should be logged into result dump file, so that user could understand that dump was taken from subset of cluster caches
>  3) when result of filter or filters AND'ing is empty set of cache names, proper error message should be given and no dump file generated.
> e.g. 
> {noformat}Error: can't find any cache matching cache names '--skup-zerus' and cache filter 'PERSISTENT', dump won't be generated.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)