[GitHub] rhtyd commented on a change in pull request #2103: CLOUDSTACK-8647 : LDAP: Auto Import and Trust AD Automation of test cases

[gi...@git.apache.org]

rhtyd commented on a change in pull request #2103: CLOUDSTACK-8647 : LDAP: Auto Import and Trust AD Automation of test cases
URL: https://github.com/apache/cloudstack/pull/2103#discussion_r116668934
 
 

 ##########
 File path: test/integration/component/test_ldap_autoImport.py
 ##########
 @@ -0,0 +1,588 @@
+from marvin.cloudstackTestCase import cloudstackTestCase
 
 Review comment:
   @sarathkouk Few comments:
   - Missing license, fix that.
   - Please also cleanup code and use pep8 to fix the styling issues.
   - Fix the filename (i.e. lower case and naming pattern) to adhere to the convention used in other test files.
   - Any new dependency such as `ddt` etc that are not already in marvin's dependency list, must be added to marvin's dependency list.
   - Also suggest how we can include this test in `blueorangutan`, what are the additional requirements/dependencies
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services