[jira] [Commented] (REEF-523) Add missing Javadoc comments/triage TODO notes in Java code: reef-common

["Mariia Mykhailova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945548#comment-14945548 ] 

Mariia Mykhailova commented on REEF-523:
----------------------------------------

[~yingdachen], [~markus.weimer], please help triage

{noformat}
org/apache/reef/runtime/common/driver/evaluator/EvaluatorManager.java
// TODO: currently we obtain the job id directly by parsing execution (container) directory path
// #845 is open to get the id from RM properly

8d4c1dc yingdachen on 6/24/2014 at 10:43 AM
add evaluator id to evaluator.conf
{noformat}

#845 seems to refer to pre-JIRA issue tracker at https://github.com/Microsoft-CISL/REEF/issues/845
This issue is resolved, but TODO stays.

----
{noformat}
org/apache/reef/runtime/common/driver/resourcemanager/ResourceManagerStatus.java
private synchronized void setState(final ReefServiceProtos.State state) {
  // TODO: Add state transition check

004a7a6 Markus Weimer on 4/3/2014 at 7:41 PM
"Refactored" the DriverManager
{noformat}
----
{noformat}
org/apache/reef/runtime/common/evaluator/DefaultDriverConnection.java
// TODO: implement a proper mechanism to obtain driver remote identifier.

55b909d yingdachen on 6/20/2014 at 11:07 AM
tmp save
{noformat}
----
{noformat}
org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java
// TODO: Find all comparisons with this and see whether we can do something about them
public static final String NONE = "NO_ERROR_HANDLER_REMOTE_ID";

9170dd7 Markus Weimer on 4/14/2014 at 3:07 PM (committed on 4/15/2014 at 6:12 PM)
Support for Client-Less Drivers
{noformat}
----

There are also several since-day-one TODOs introduced in
{noformat}
1b6a773 Rusty Sears on 11/7/2013 at 12:59 PM
Initial check-in
{noformat}

{noformat}
org/apache/reef/driver/PreemptionEvent.java
// TODO: We need to have a set of things to present to the user as preempted.
// Probably a Set<String> with the Evaluator IDs.
// public Set<RunningEvaluator> getToBePreemptedEvaluators();
{noformat}

This interface is used in FlexiblePreemptionEvent and StrictPreemptionEvent which are unused themselves; do we need them?

{noformat}
org/apache/reef/runtime/common/driver/evaluator/EvaluatorState.java
// TODO: Add CLOSING state
{noformat}

{noformat}
org/apache/reef/runtime/common/evaluator/HeartBeatManager.java
// TODO: Write a test that checks for the order.
{noformat}

{noformat}
org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java
// TODO: Which lock guards this?
{noformat}

{noformat}
org/apache/reef/runtime/common/launch/REEFErrorHandler.java
// TODO: This gets a new EventHandler each time an exception is caught. It would be better to cache the handler. But
// that introduces threading issues and isn't really worth it, as the JVM typically will be killed once we catch an
// Exception in here.
{noformat}

If this TODO itself says "not worth it", maybe we don't need this?


> Add missing Javadoc comments/triage TODO notes in Java code: reef-common
> ------------------------------------------------------------------------
>
>                 Key: REEF-523
>                 URL: https://issues.apache.org/jira/browse/REEF-523
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF-Common
>            Reporter: Mariia Mykhailova
>            Priority: Minor
>
> See parent JIRA for description



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)