You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/10/26 12:29:51 UTC
[PR] Foix for jena-iri IRI.isAbsolute [jena]
afs opened a new pull request, #2061:
URL: https://github.com/apache/jena/pull/2061
GitHub issue resolved #2060
This closes #2060
Various fixes in in ARP show that the change works. Several "isAbsolute" needed to be "!isRelative".
----
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Fix for jena-iri IRI.isAbsolute [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #2061:
URL: https://github.com/apache/jena/pull/2061#issuecomment-1781191934
Tests added.
Largely, I'd coded around the problem by using "isRelative" and "! isRelative" but with tests the change is pushed down in jena-iri.
I found this while comparing jena-iri with [iri4ld](https://github.com/afs/x4ld/tree/main/iri4ld) and there'll be comparison tests for different `IRIPRovider` implementations some time. This is all about being very, very careful in exact expected behaviour of IRIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Fix for jena-iri IRI.isAbsolute [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #2061:
URL: https://github.com/apache/jena/pull/2061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org