You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 10:42:04 UTC
[GitHub] [flink] liyafan82 opened a new pull request #10809: [FLINK-15538]
Separate decimal implementations into separate sub-classes
liyafan82 opened a new pull request #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The current implementation of Decimal values have two (somewhat independent) implementations: one is based on Long, while the other is based on BigDecimal.
This makes the Decmial class not clear (both implementations cluttered in a single class) and less efficient (each method involves a if-else branch).
So in this issue, we make Decimal an abstract class, and separate the two implementation into two sub-classes. This makes the code clearer and more efficient.
## Brief change log
- Make decimal an abstract class
- Provide two subclasses for the implementation of Long and BigDecimal
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10809: [FLINK-15538]
Separate decimal implementations into separate sub-classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809#issuecomment-572517529
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a8055c21a4c5c246607fe1ab2d26095531f2699e",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/143714034",
"triggerID" : "a8055c21a4c5c246607fe1ab2d26095531f2699e",
"triggerType" : "PUSH"
}, {
"hash" : "a8055c21a4c5c246607fe1ab2d26095531f2699e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217",
"triggerID" : "a8055c21a4c5c246607fe1ab2d26095531f2699e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8055c21a4c5c246607fe1ab2d26095531f2699e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714034) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10809: [FLINK-15538] Separate
decimal implementations into separate sub-classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809#issuecomment-572517529
<!--
Meta data
Hash:a8055c21a4c5c246607fe1ab2d26095531f2699e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a8055c21a4c5c246607fe1ab2d26095531f2699e
-->
## CI report:
* a8055c21a4c5c246607fe1ab2d26095531f2699e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10809: [FLINK-15538]
Separate decimal implementations into separate sub-classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809#issuecomment-572517529
<!--
Meta data
Hash:a8055c21a4c5c246607fe1ab2d26095531f2699e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714034 TriggerType:PUSH TriggerID:a8055c21a4c5c246607fe1ab2d26095531f2699e
Hash:a8055c21a4c5c246607fe1ab2d26095531f2699e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217 TriggerType:PUSH TriggerID:a8055c21a4c5c246607fe1ab2d26095531f2699e
-->
## CI report:
* a8055c21a4c5c246607fe1ab2d26095531f2699e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714034) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10809: [FLINK-15538] Separate
decimal implementations into separate sub-classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809#issuecomment-572504661
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a8055c21a4c5c246607fe1ab2d26095531f2699e (Thu Jan 09 10:45:52 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15538).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10809: [FLINK-15538]
Separate decimal implementations into separate sub-classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10809: [FLINK-15538] Separate decimal implementations into separate sub-classes
URL: https://github.com/apache/flink/pull/10809#issuecomment-572517529
<!--
Meta data
Hash:a8055c21a4c5c246607fe1ab2d26095531f2699e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714034 TriggerType:PUSH TriggerID:a8055c21a4c5c246607fe1ab2d26095531f2699e
Hash:a8055c21a4c5c246607fe1ab2d26095531f2699e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217 TriggerType:PUSH TriggerID:a8055c21a4c5c246607fe1ab2d26095531f2699e
-->
## CI report:
* a8055c21a4c5c246607fe1ab2d26095531f2699e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714034) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services