[GitHub] [maven-jxr] michael-o commented on a diff in pull request #62: [JXR-172] Upgrade Parent to 37, project cleanup

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #62:
URL: https://github.com/apache/maven-jxr/pull/62#discussion_r929611563


##########
maven-jxr-plugin/src/it/settings.xml:
##########
@@ -60,18 +46,10 @@ under the License.
             <enabled>true</enabled>
           </snapshots>
         </pluginRepository>
-        <pluginRepository>
-          <id>apache.snapshots</id>
-          <name>Apache Snapshot Repository</name>
-          <url>http://repository.apache.org/content/groups/snapshots/</url>
-          <releases>
-            <enabled>false</enabled>
-          </releases>
-          <snapshots>
-            <enabled>true</enabled>
-          </snapshots>
-        </pluginRepository>        
       </pluginRepositories>
     </profile>
   </profiles>
+  <activeProfiles>
+    <activeProfile>it-repo</activeProfile>
+  </activeProfiles>
 </settings>

Review Comment:
   Why do we need this settings file at all? I ran the tests without and they success. There is no settings file in MPIR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org