You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2021/11/06 17:32:32 UTC

[GitHub] [lucenenet] NightOwl888 opened a new pull request #534: Lucene.Net.Replicator Bug Fixes (Fixes #363)

NightOwl888 opened a new pull request #534:
URL: https://github.com/apache/lucenenet/pull/534


   This fixes several issues with `Lucene.Net.Replicator`.
   
   #### Failing Intermittently
   
   - `Lucene.Net.Replicator.Http.HttpReplicatorTest::TestBasic()`
   
   This was failing due to the `Timeout` value being set to 1 second instead of the 60 second value that was used in Java. It has been increased to the .NET default of 100 seconds.
   
   Fixes #363
   
   #### Failing Intermittently & Deadlocking Intermittently
   
   - `Lucene.Net.Replicator.IndexAndTaxonomyReplicationClientTest::TestConsistencyOnExceptions()`
   - `Lucene.Net.Replicator.IndexReplicationClientTest::TestConsistencyOnExceptions()`
   
   These were failing due to the fact that they were throwing exceptions on the worker thread, which causes it to stop immediately when they are unhandled. The `Lucene.Net.Replicator.ReplicationClient.ReplicationThread` class was re-ported from Lucene 4.8.1 to subclass `ThreadJob` which handles re-throwing any unhandled exception when calling `Join()` on the thread.
   
   There were also 4 methods that were missing locks in `Lucene.Net.Replicator.ReplicationClient` that likely explains why we were getting deadlocks.
   
   The rest of the replicator changes were also ported from Lucene 4.8.1, and `ReplicatorTestCase` was set up to use a .NET 5 example using `ReplicationService` as middleware with its own endpoint mapping, which allows other routes to be handled elsewhere rather than being the only termination point.
   
   The throw statements and catch blocks were also reviewed to make sure we aren't swallowing exceptions we shouldn't be.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #534: Lucene.Net.Replicator Bug Fixes (Fixes #363)

Posted by GitBox <gi...@apache.org>.
NightOwl888 merged pull request #534:
URL: https://github.com/apache/lucenenet/pull/534


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org