[GitHub] [arrow-datafusion] ozankabak commented on pull request #5918: Use generics instead of borrow for zero-cost

["ozankabak (via GitHub)" <gi...@apache.org>]

ozankabak commented on PR #5918:
URL: https://github.com/apache/arrow-datafusion/pull/5918#issuecomment-1500409843

   It needs:
   ```rust
   impl From<&PhysicalSortRequirement> for PhysicalSortExpr {
       fn from(value: &PhysicalSortRequirement) -> Self {
           value.clone().into_sort_expr()
       }
   }
   ```
   and
   ```rust
   impl From<&PhysicalSortExpr> for PhysicalSortRequirement {
       fn from(value: &PhysicalSortExpr) -> Self {
           PhysicalSortRequirement::from(value.clone())
       }
   }
   ```
   so that `to_sort_exprs` and `from_sort_exprs` can work with both reference and owned arguments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org