You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/12/13 14:19:39 UTC

[GitHub] nifi-minifi pull request #105: MINIFI-418: Added docs on Windows service for...

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi-minifi/pull/105

    MINIFI-418: Added docs on Windows service for 64bit machine

    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi-minifi minifi-418

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit ee73f8c0bdd7dfc5e95e01eabd7546351da3aaec
Author: Koji Kawamura <ij...@gmail.com>
Date:   2017-12-13T14:10:36Z

    MINIFI-418: Added docs on Windows service for 64bit machine

----


---

[GitHub] nifi-minifi pull request #105: MINIFI-418: Added docs on Windows service for...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak closed the pull request at:

    https://github.com/apache/nifi-minifi/pull/105


---