You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/23 10:48:04 UTC

[GitHub] [incubator-dolphinscheduler] zhanguohao commented on pull request #4845: [Fix-#4840][worker] fix master fault tolerance when startup

zhanguohao commented on pull request #4845:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4845#issuecomment-784109767


   > Is it better to move `this.masterRegistry.unRegistry()` in `this.zkMasterClient.close()` as well?
   Here is still needed, need to cancel the registration in time when the program exits 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org