[GitHub] [solr] dsmiley commented on a diff in pull request #1869: logging, MDC: collection for action=DELETE

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on code in PR #1869:
URL: https://github.com/apache/solr/pull/1869#discussion_r1311702971


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java:
##########
@@ -113,7 +113,9 @@ public OverseerCollectionMessageHandler(
 
   @Override
   public OverseerSolrResponse processMessage(ZkNodeProps message, String operation) {
-    MDCLoggingContext.setCollection(message.getStr(COLLECTION));
+    // sometimes overseer messages have the collection name in 'name' field, not 'collection'
+    MDCLoggingContext.setCollection(
+        message.getStr(COLLECTION) != null ? message.getStr(COLLECTION) : message.getStr(NAME));

Review Comment:
   I'll switch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org