You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/19 10:07:28 UTC

[GitHub] [spark] wangyum opened a new pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

wangyum opened a new pull request #31243:
URL: https://github.com/apache/spark/pull/31243


   ### What changes were proposed in this pull request?
   
   This pr add partition columns for TPCDS tables. The partition column is consistent with the [TPCDSTables](https://github.com/databricks/spark-sql-perf/blob/master/src/main/scala/com/databricks/spark/sql/perf/tpcds/TPCDSTables.scala).
   
   
   ### Why are the changes needed?
   
   Better track plan changes. For example, [this is the change](https://github.com/apache/spark/commit/3fe1a93a4038a74f2d987ff8a74a90c7f4749a48) after SPARK-34119.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on a change in pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31243:
URL: https://github.com/apache/spark/pull/31243#discussion_r560598910



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -271,6 +271,23 @@ trait TPCDSBase extends SharedSparkSession {
       """.stripMargin
   )
 
+  private val tablePartitionColumns = Map(

Review comment:
       nit: Could you leave some comments about how we decided these partition keys?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762896108


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134227/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762865833


   **[Test build #134227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134227/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762768858


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762902441


   **[Test build #134230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134230/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763338030


   **[Test build #134245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134245/testReport)** for PR 31243 at commit [`e30f20b`](https://github.com/apache/spark/commit/e30f20b6884b8de65e71fb80134d6958bb64d051).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762803097


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38810/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762931102


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38815/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762744524


   **[Test build #134223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134223/testReport)** for PR 31243 at commit [`3fe1a93`](https://github.com/apache/spark/commit/3fe1a93a4038a74f2d987ff8a74a90c7f4749a48).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762796525


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134226/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762955034


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38815/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763275262


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38830/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762768261


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38808/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762744325


   The actual change is: 
   ```diff
   diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   index 9f420cac97..2fe79b273d 100644
   --- a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   +++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   @@ -271,6 +271,41 @@ trait TPCDSBase extends SharedSparkSession {
          """.stripMargin
      )
    
   +  private val tablePartitionColumns = Map(
   +    "catalog_sales" -> Seq("cs_sold_date_sk"),
   +    "catalog_returns" -> Seq("cr_returned_date_sk"),
   +    "inventory" -> Seq("inv_date_sk"),
   +    "store_sales" -> Seq("ss_sold_date_sk"),
   +    "store_returns" -> Seq("sr_returned_date_sk"),
   +    "web_sales" -> Seq("ws_sold_date_sk"),
   +    "web_returns" -> Seq("wr_returned_date_sk"),
   +    "call_center" -> Seq.empty[String],
   +    "catalog_page" -> Seq.empty[String],
   +    "customer" -> Seq.empty[String],
   +    "customer_address" -> Seq.empty[String],
   +    "customer_demographics" -> Seq.empty[String],
   +    "date_dim" -> Seq.empty[String],
   +    "household_demographics" -> Seq.empty[String],
   +    "income_band" -> Seq.empty[String],
   +    "item" -> Seq.empty[String],
   +    "promotion" -> Seq.empty[String],
   +    "reason" -> Seq.empty[String],
   +    "ship_mode" -> Seq.empty[String],
   +    "store" -> Seq.empty[String],
   +    "time_dim" -> Seq.empty[String],
   +    "warehouse" -> Seq.empty[String],
   +    "web_page" -> Seq.empty[String],
   +    "web_site" -> Seq.empty[String]
   +  )
   +
   +  private def partitionedByClause(tableName: String) = {
   +    if (tablePartitionColumns(tableName).nonEmpty) {
   +      s"PARTITIONED BY (${tablePartitionColumns(tableName).mkString(", ")})"
   +    } else {
   +      ""
   +    }
   +  }
   +
      val tableNames: Iterable[String] = tableColumns.keys
    
      def createTable(
   @@ -282,6 +317,7 @@ trait TPCDSBase extends SharedSparkSession {
          s"""
             |CREATE TABLE `$tableName` (${tableColumns(tableName)})
             |USING $format
   +         |${partitionedByClause(tableName)}
             |${options.mkString("\n")}
           """.stripMargin)
      }
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763257733


   **[Test build #134245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134245/testReport)** for PR 31243 at commit [`e30f20b`](https://github.com/apache/spark/commit/e30f20b6884b8de65e71fb80134d6958bb64d051).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762824363


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38810/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762978843


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38815/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762831410


   **[Test build #134227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134227/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
wangyum removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762744325


   The actual change is: 
   ```diff
   diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   index 9f420cac97..2fe79b273d 100644
   --- a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   +++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
   @@ -271,6 +271,41 @@ trait TPCDSBase extends SharedSparkSession {
          """.stripMargin
      )
    
   +  private val tablePartitionColumns = Map(
   +    "catalog_sales" -> Seq("cs_sold_date_sk"),
   +    "catalog_returns" -> Seq("cr_returned_date_sk"),
   +    "inventory" -> Seq("inv_date_sk"),
   +    "store_sales" -> Seq("ss_sold_date_sk"),
   +    "store_returns" -> Seq("sr_returned_date_sk"),
   +    "web_sales" -> Seq("ws_sold_date_sk"),
   +    "web_returns" -> Seq("wr_returned_date_sk"),
   +    "call_center" -> Seq.empty[String],
   +    "catalog_page" -> Seq.empty[String],
   +    "customer" -> Seq.empty[String],
   +    "customer_address" -> Seq.empty[String],
   +    "customer_demographics" -> Seq.empty[String],
   +    "date_dim" -> Seq.empty[String],
   +    "household_demographics" -> Seq.empty[String],
   +    "income_band" -> Seq.empty[String],
   +    "item" -> Seq.empty[String],
   +    "promotion" -> Seq.empty[String],
   +    "reason" -> Seq.empty[String],
   +    "ship_mode" -> Seq.empty[String],
   +    "store" -> Seq.empty[String],
   +    "time_dim" -> Seq.empty[String],
   +    "warehouse" -> Seq.empty[String],
   +    "web_page" -> Seq.empty[String],
   +    "web_site" -> Seq.empty[String]
   +  )
   +
   +  private def partitionedByClause(tableName: String) = {
   +    if (tablePartitionColumns(tableName).nonEmpty) {
   +      s"PARTITIONED BY (${tablePartitionColumns(tableName).mkString(", ")})"
   +    } else {
   +      ""
   +    }
   +  }
   +
      val tableNames: Iterable[String] = tableColumns.keys
    
      def createTable(
   @@ -282,6 +317,7 @@ trait TPCDSBase extends SharedSparkSession {
          s"""
             |CREATE TABLE `$tableName` (${tableColumns(tableName)})
             |USING $format
   +         |${partitionedByClause(tableName)}
             |${options.mkString("\n")}
           """.stripMargin)
      }
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762796525


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134226/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on a change in pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31243:
URL: https://github.com/apache/spark/pull/31243#discussion_r560605695



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -271,6 +271,23 @@ trait TPCDSBase extends SharedSparkSession {
       """.stripMargin
   )
 
+  private val tablePartitionColumns = Map(

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762978843


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38815/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763295274


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38830/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762849830


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38812/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762824363


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38810/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763092764


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134230/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] peter-toth commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763452274


   LGTM, PlanStabilitySuite should work on partitioned tables


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763085610


   **[Test build #134230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134230/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763357278


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134245/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762775072


   **[Test build #134226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134226/testReport)** for PR 31243 at commit [`3fe1a93`](https://github.com/apache/spark/commit/3fe1a93a4038a74f2d987ff8a74a90c7f4749a48).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762768261


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38808/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762860808


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38812/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31243:
URL: https://github.com/apache/spark/pull/31243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763295274


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38830/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-766288033


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763357278


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134245/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762860849


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38812/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762767047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134223/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763092764


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134230/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763292051


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38830/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762902441


   **[Test build #134230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134230/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762860849


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38812/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762896108


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134227/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762794583


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38810/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762831410


   **[Test build #134227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134227/testReport)** for PR 31243 at commit [`b0046ad`](https://github.com/apache/spark/commit/b0046ad6062ab60d9a46329baf549b30b04f7edd).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762767047


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134223/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763257733


   **[Test build #134245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134245/testReport)** for PR 31243 at commit [`e30f20b`](https://github.com/apache/spark/commit/e30f20b6884b8de65e71fb80134d6958bb64d051).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] peter-toth edited a comment on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
peter-toth edited a comment on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763452274






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-763246537


   cc @maropu and @peter-toth too


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762744524


   **[Test build #134223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134223/testReport)** for PR 31243 at commit [`3fe1a93`](https://github.com/apache/spark/commit/3fe1a93a4038a74f2d987ff8a74a90c7f4749a48).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762764349


   **[Test build #134223 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134223/testReport)** for PR 31243 at commit [`3fe1a93`](https://github.com/apache/spark/commit/3fe1a93a4038a74f2d987ff8a74a90c7f4749a48).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #31243: [SPARK-34155][SQL][TEST] Add partition columns for TPCDS tables

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31243:
URL: https://github.com/apache/spark/pull/31243#issuecomment-762866352


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org