You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/08 03:45:02 UTC

[GitHub] [iceberg] openinx opened a new pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

openinx opened a new pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180


   This patch will address the issue from https://github.com/apache/iceberg/issues/1176. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx commented on pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180#issuecomment-655852092


   Ping @rdblue & @rdsr ,  PTAL. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180#issuecomment-656240658


   I agree with doing this. Locking is really helpful when building a final app so you can ensure tests run with the same classpath that will be used in production. For a library like this, it makes far less sense. Huge lock files and confusing behavior when updating versions is not worth it.
   
   Before merging, I think we should remove the dependency lock plugin as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180#issuecomment-657804600


   Looks like there isn't much more discussion. I'm going to merge this. Thanks @openinx and to everyone that took the time to review!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx commented on pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180#issuecomment-656442300


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on a change in pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180#discussion_r452358677



##########
File path: build.gradle
##########
@@ -103,6 +103,7 @@ subprojects {
   compileJava {
     options.encoding = "UTF-8"
   }
+  compileJava.dependsOn(generateLock, saveLock)

Review comment:
       We should remove the locking plugin as well, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #1180: Remove the dependencies.lock from git and make them re-generated when building project

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1180:
URL: https://github.com/apache/iceberg/pull/1180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org