You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/03 03:42:03 UTC
[GitHub] [flink] carp84 commented on a change in pull request #10692:
[FLINK-15387] Expose missing RocksDB properties out via
RocksDBNativeMetricOptions
carp84 commented on a change in pull request #10692: [FLINK-15387] Expose missing RocksDB properties out via RocksDBNativeMetricOptions
URL: https://github.com/apache/flink/pull/10692#discussion_r362699520
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -153,6 +153,30 @@
.defaultValue(false)
.withDescription("Monitor the current actual delayed write rate. 0 means no delay.");
+ public static final ConfigOption<Boolean> IS_WRITE_STOPPED = ConfigOptions
+ .key(RocksDBProperty.IsWriteStopped.getConfigKey())
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Monitor whether write has been stopped. 1 means that has been stopped.");
Review comment:
Suggest to follow the same description pattern as `CompactionPending`:
"Track whether write has been stopped in RocksDB. Returns 1 if write has been stopped, 0 otherwise."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services