You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "JoneWeng (GitHub)" <gi...@apache.org> on 2018/11/28 08:00:46 UTC

[GitHub] [incubator-dubbo] JoneWeng opened issue #2843: Telnet does not support invoke a method of set parameter

- [ x ] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [ x ] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version:  latest
* Operating System version:  mac
* Java version: 1.8

### Steps to reproduce this issue
1. 
```java
public interface DemoService {
    
    int getSetSize(Set set);
    int getListSize(List list);
    
}
```
2. telnet localhost 20881
3. invoke xxx.getListSize([1,2,3])    
4. invoke xxx.getSetSize([1,2,3])  

### Expected Result

3. ok
4. ok


### Actual Result

3. ok
4. No suck method


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang closed issue #2843: Telnet does not support invoke a method of set parameter

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ issue closed by zonghaishang ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] JoneWeng commented on issue #2843: Telnet does not support invoke a method of set parameter

Posted by "JoneWeng (GitHub)" <gi...@apache.org>.
no,  did not resolve this problem

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang commented on issue #2843: Telnet does not support invoke a method of set parameter

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
`invoke DemoService.getSetSize(Set[1,2,3])`

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kexianjun commented on issue #2843: Telnet does not support invoke a method of set parameter

Posted by "kexianjun (GitHub)" <gi...@apache.org>.
may this pr #2801  can solve you problem.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] JoneWeng commented on issue #2843: Telnet does not support invoke a method of set parameter

Posted by "JoneWeng (GitHub)" <gi...@apache.org>.
the cause of the problem:  org.apache.dubbo.rpc.protocol.dubbo.telnet.InvokeTelnetHandler#isMatch

    // arg(JSONArray instance) is Assignable From List
    // Set not match
    else if (arg instanceof Collection) {
            if (!type.isArray() && !type.isAssignableFrom(arg.getClass())) {
                return false;
            }
    }

actually,   PojoUtils#realize can convert JSONArray to Set


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2843 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org