You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2020/02/07 14:36:53 UTC

[Impala-ASF-CR] IMPALA-6663: Expose current DDL metrics on WebUI

Tamas Mate has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13806 )

Change subject: IMPALA-6663: Expose current DDL metrics on WebUI
......................................................................

IMPALA-6663: Expose current DDL metrics on WebUI

This change adds a new '/operations' tab to the Catalog WebUI. On  this
page the users can see two summary tables, the first report is based on
how many catalog operations are running and which tables are involved.
The second report shows the number of catalog operations on table level.

A new 'monitor' package is created to collect the monitoring classes.
Each DDL/FinalizeDML/ResetMetada request get a class with common base
class. The output of these classes are summarized and can be accessed
with a new JNI call.

A screenshot of the new '/operations' page can be found in the Jira.

Testing:
Unit tests were added to test the counters and a web server test to
verify the availability of the page.

Change-Id: I0ed76f134bad6d3b3d4dce132365a53a01e9512a
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogDdlCounter.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogFinalizeDmlCounter.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogMonitor.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationCounter.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationMetrics.java
A fe/src/main/java/org/apache/impala/catalog/monitor/CatalogResetMetadataCounter.java
R fe/src/main/java/org/apache/impala/catalog/monitor/CatalogTableMetrics.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
A fe/src/test/java/org/apache/impala/catalog/monitor/CatalogDdlCounterTest.java
A fe/src/test/java/org/apache/impala/catalog/monitor/CatalogFinalizeDmlCounterTest.java
A fe/src/test/java/org/apache/impala/catalog/monitor/CatalogResetMetadataCounterTest.java
M tests/webserver/test_web_pages.py
A www/catalog_operations.tmpl
22 files changed, 1,260 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/13806/11
-- 
To view, visit http://gerrit.cloudera.org:8080/13806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ed76f134bad6d3b3d4dce132365a53a01e9512a
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 11
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>