[PATCH] Properly format the error message for the 'svn diff --old A --new B' commands

[Evgeny Kotkov <ev...@visualsvn.com>]

Hi,

Currently it is possible to compare arbitrary versioned or unversioned files or
directories using the 'svn diff --old A --new B' command [1].  Running this
command may produce errors and on my Windows machine the
corresponding error messages contain paths with incorrect separators.

- For example, running 'svn diff --old doc --new win-tests.py' on a fresh
subversion/trunk checkout produces the following message:

[[[
svn: E145001: 'C:/Projects/Subversion/doc' is not the same node kind as
'C:/Projects/Subversion/win-tests.py'
]]]

- Running 'svn diff --old DOES-NOT-EXIST --new DOES-NOT-EXIST' in the same case
produces the following message:

[[[
svn: E145001: 'C:/Projects/Subversion/DOES-NOT-EXIST' is not a file or directory
]]]

I've attached a patch that fixes the described problems (we should use
'svn_dirent_local_style' for path formatting in the error messages produced by
the 'svn_client__arbitrary_nodes_diff' function).

[1] http://svn.apache.org/viewvc?view=revision&revision=1310291


Thanks and regards,
Evgeny Kotkov

Re: [PATCH] Properly format the error message for the 'svn diff --old A --new B' commands

[Stefan Sperling <st...@elego.de>]

On Mon, Jul 08, 2013 at 03:57:16PM +0400, Evgeny Kotkov wrote:
> I've attached a patch that fixes the described problems (we should use
> 'svn_dirent_local_style' for path formatting in the error messages produced by
> the 'svn_client__arbitrary_nodes_diff' function).
> 
> [1] http://svn.apache.org/viewvc?view=revision&revision=1310291

Thanks, committed in r1500680 and nominated for 1.8.x.