[GitHub] [bookkeeper] Ghatage opened a new pull request #2203: Issue #609 Add indexDirs field to cookie

[GitBox <gi...@apache.org>]

Ghatage opened a new pull request #2203: Issue #609 Add indexDirs field to cookie
URL: https://github.com/apache/bookkeeper/pull/2203
 
 
    ### Motivation
    Currently users add indexDirectories to ledgerDirectories, if they swap their configs it may result in data loss.
   
    ### Changes
    - Add indexDirectories field to cookie. Bump up Cookie layout version.
    - Add indexDirs initialization to some test suites
    - Add config option 'enforceCookieIndexDirCheck' to disable checking cookie for indexDirs (for backward compat). Keeping this to default to `false` right now. 
    - Add basic tests to check for compatibility of v5 cookie in v4 cluster.
   
   Once review passes:
   - Future plan to create BookieShell tool to update existing cookie to v5 and add indexDir to it.
   
   Opening this as a draft PR right now as this is a WIP.
   There are many tests which are going to fail with `InvalidCookieException` because we need to `.setIndexDirName()` in the ServerConfig being passed around in the test.
   I will get to them in another following commit once the team approves of the underlying changes.
   
   Master Issue: #609 
   
   Signed off by: Anup Ghatage ghatageanup@gmail.com

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services