You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/04/21 15:02:12 UTC
Review Request: Sqoop2: sqoop.sh execution error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Problem while starting and stopping sqoop server.
Patch supports softlink for both server and client command.
This addresses bug SQOOP-1003.
https://issues.apache.org/jira/browse/SQOOP-1003
Diffs
-----
dist/src/main/bin/sqoop.sh a218441
Diff: https://reviews.apache.org/r/10689/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by rj...@gmail.com.
> On May 2, 2013, 12:33 a.m., Jarek Cecho wrote:
> > dist/src/main/bin/sqoop.sh, lines 51-53
> > <https://reviews.apache.org/r/10689/diff/2/?file=286744#file286744line51>
> >
> > Nit: It seems that the cd on line 50 is not necessary as we've already changed the working directory on line 48 if I'm not mistaken.
Hi Jarcec,
At line 48, just getting value and not actually changing directory. I tried 'pwd' command at before and after the 48th line, prints same path. Only at line 50, actually changing directory path.
Even I removed line 50 as per your suggestion, getting execution error at line 93.
Thanks,
Vasanth kumar
- vasanthkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20040
-----------------------------------------------------------
On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 7:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by Jarek Cecho <ja...@apache.org>.
> On May 2, 2013, 12:33 a.m., Jarek Cecho wrote:
> > dist/src/main/bin/sqoop.sh, lines 51-53
> > <https://reviews.apache.org/r/10689/diff/2/?file=286744#file286744line51>
> >
> > Nit: It seems that the cd on line 50 is not necessary as we've already changed the working directory on line 48 if I'm not mistaken.
>
> vasanthkumar wrote:
> Hi Jarcec,
> At line 48, just getting value and not actually changing directory. I tried 'pwd' command at before and after the 48th line, prints same path. Only at line 50, actually changing directory path.
> Even I removed line 50 as per your suggestion, getting execution error at line 93.
>
> Thanks,
> Vasanth kumar
Thank you for verifying Vasanth!
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20040
-----------------------------------------------------------
On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 7:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20040
-----------------------------------------------------------
Hi Vasanth,
thank you for your time and effort with this!
dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10689/#comment41295>
Nit: It seems that the cd on line 50 is not necessary as we've already changed the working directory on line 48 if I'm not mistaken.
Jarcec
- Jarek Cecho
On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 7:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20106
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 7:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by rj...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/
-----------------------------------------------------------
(Updated May 1, 2013, 7:02 p.m.)
Review request for Sqoop.
Changes
-------
Implemented Jarek's comments
Description
-------
Problem while starting and stopping sqoop server.
Patch supports softlink for both server and client command.
This addresses bug SQOOP-1003.
https://issues.apache.org/jira/browse/SQOOP-1003
Diffs (updated)
-----
dist/src/main/bin/sqoop.sh a218441
Diff: https://reviews.apache.org/r/10689/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by rj...@gmail.com.
> On May 1, 2013, 4:48 p.m., Jarek Cecho wrote:
> > dist/src/main/bin/sqoop.sh, lines 52-53
> > <https://reviews.apache.org/r/10689/diff/1/?file=282985#file282985line52>
> >
> > I think that those two lines are not necessary at this point. We might need to change all CUR_DIR occurrences to BASEDIR though.
added:
cd ${BASEDIR}
- vasanthkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20008
-----------------------------------------------------------
On May 1, 2013, 7:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 7:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>
Re: Review Request: Sqoop2: sqoop.sh execution error
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10689/#review20008
-----------------------------------------------------------
Thank you Vasanth,
I do have just two nits:
dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10689/#comment41240>
Can we remove this line? The BASEDIR is being printed out later in more user friendly manner.
dist/src/main/bin/sqoop.sh
<https://reviews.apache.org/r/10689/#comment41241>
I think that those two lines are not necessary at this point. We might need to change all CUR_DIR occurrences to BASEDIR though.
Jarcec
- Jarek Cecho
On April 21, 2013, 1:02 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10689/
> -----------------------------------------------------------
>
> (Updated April 21, 2013, 1:02 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Problem while starting and stopping sqoop server.
> Patch supports softlink for both server and client command.
>
>
> This addresses bug SQOOP-1003.
> https://issues.apache.org/jira/browse/SQOOP-1003
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop.sh a218441
>
> Diff: https://reviews.apache.org/r/10689/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>