[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #4024: Fix read write request leak when executor throw `RejectedExecutionException`

["horizonzy (via GitHub)" <gi...@apache.org>]

horizonzy commented on code in PR #4024:
URL: https://github.com/apache/bookkeeper/pull/4024#discussion_r1264593489


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java:
##########
@@ -703,6 +706,7 @@ private void processReadRequest(final BookieProtocol.ReadRequest r, final Bookie
                     ResponseBuilder.buildErrorResponse(BookieProtocol.ETOOMANYREQUESTS, r),
                     requestStats.getReadRequestStats());
                 onReadRequestFinish();
+                read.recycle();

Review Comment:
   Here we should also recycle the request `r`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org