You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2025/04/14 08:13:01 UTC
[PR] [CORE] Correct handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
zhztheplayer opened a new pull request, #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312
`spark.sql.extensions=org.apache.gluten.extension.GlutenSessionExtensions` should be set automatically when Spark driver started with Gluten. However if user explicitly sets it, unexpected errors will be caused. For example:
```
java.lang.UnsupportedOperationException: This operator doesn't support doTransform with SubstraitContext.
at org.apache.gluten.execution.TransformSupport.doTransform(WholeStageTransformer.scala:192)
at org.apache.gluten.execution.TransformSupport.doTransform$(WholeStageTransformer.scala:190)
at org.apache.gluten.execution.WholeStageTransformer.doTransform(WholeStageTransformer.scala:222)
at org.apache.gluten.execution.TransformSupport.$anonfun$transform$1(WholeStageTransformer.scala:185)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$executeQuery$1(SparkPlan.scala:246)
at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:243)
```
The patch enhances relevant logic to handle this case correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2802419551
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_04_14_2025_time.csv</font></td>
<td><font color=#000000>log/native_master_04_13_2025_cb35706408_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>11.38</font></td>
<td><font color=#6F9915>10.92</font></td>
<td><font color=#6F9915>-0.455</font></td>
<td><font color=#6F9915>96.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>11.11</font></td>
<td><font color=#F92663>11.23</font></td>
<td><font color=#F92663>0.117</font></td>
<td><font color=#F92663>101.05%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>3.11</font></td>
<td><font color=#6F9915>2.75</font></td>
<td><font color=#6F9915>-0.366</font></td>
<td><font color=#6F9915>88.24%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>52.09</font></td>
<td><font color=#6F9915>50.99</font></td>
<td><font color=#6F9915>-1.105</font></td>
<td><font color=#6F9915>97.88%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>10.10</font></td>
<td><font color=#6F9915>8.32</font></td>
<td><font color=#6F9915>-1.785</font></td>
<td><font color=#6F9915>82.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>4.86</font></td>
<td><font color=#6F9915>4.53</font></td>
<td><font color=#6F9915>-0.328</font></td>
<td><font color=#6F9915>93.26%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>5.52</font></td>
<td><font color=#6F9915>4.33</font></td>
<td><font color=#6F9915>-1.184</font></td>
<td><font color=#6F9915>78.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>4.95</font></td>
<td><font color=#F92663>6.27</font></td>
<td><font color=#F92663>1.327</font></td>
<td><font color=#F92663>126.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>16.09</font></td>
<td><font color=#6F9915>14.24</font></td>
<td><font color=#6F9915>-1.848</font></td>
<td><font color=#6F9915>88.51%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>12.40</font></td>
<td><font color=#6F9915>11.93</font></td>
<td><font color=#6F9915>-0.474</font></td>
<td><font color=#6F9915>96.18%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>28.14</font></td>
<td><font color=#F92663>28.70</font></td>
<td><font color=#F92663>0.559</font></td>
<td><font color=#F92663>101.98%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>2.06</font></td>
<td><font color=#F92663>2.77</font></td>
<td><font color=#F92663>0.712</font></td>
<td><font color=#F92663>134.64%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>6.59</font></td>
<td><font color=#6F9915>5.25</font></td>
<td><font color=#6F9915>-1.341</font></td>
<td><font color=#6F9915>79.66%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14a</font></td>
<td><font color=#F92663>43.28</font></td>
<td><font color=#F92663>44.32</font></td>
<td><font color=#F92663>1.047</font></td>
<td><font color=#F92663>102.42%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14b</font></td>
<td><font color=#6F9915>39.83</font></td>
<td><font color=#6F9915>38.67</font></td>
<td><font color=#6F9915>-1.162</font></td>
<td><font color=#6F9915>97.08%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>2.22</font></td>
<td><font color=#F92663>2.70</font></td>
<td><font color=#F92663>0.476</font></td>
<td><font color=#F92663>121.44%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>5.06</font></td>
<td><font color=#F92663>5.66</font></td>
<td><font color=#F92663>0.594</font></td>
<td><font color=#F92663>111.74%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>7.83</font></td>
<td><font color=#6F9915>6.22</font></td>
<td><font color=#6F9915>-1.612</font></td>
<td><font color=#6F9915>79.41%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>8.06</font></td>
<td><font color=#6F9915>7.58</font></td>
<td><font color=#6F9915>-0.476</font></td>
<td><font color=#6F9915>94.10%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>4.57</font></td>
<td><font color=#6F9915>3.39</font></td>
<td><font color=#6F9915>-1.173</font></td>
<td><font color=#6F9915>74.30%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>2.09</font></td>
<td><font color=#6F9915>1.69</font></td>
<td><font color=#6F9915>-0.400</font></td>
<td><font color=#6F9915>80.86%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>0.77</font></td>
<td><font color=#F92663>1.12</font></td>
<td><font color=#F92663>0.346</font></td>
<td><font color=#F92663>144.87%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>3.47</font></td>
<td><font color=#6F9915>2.88</font></td>
<td><font color=#6F9915>-0.593</font></td>
<td><font color=#6F9915>82.92%</font></td>
</tr>
<tr>
<td><font color=#F92663>q23a</font></td>
<td><font color=#F92663>60.51</font></td>
<td><font color=#F92663>60.93</font></td>
<td><font color=#F92663>0.413</font></td>
<td><font color=#F92663>100.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q23b</font></td>
<td><font color=#F92663>71.34</font></td>
<td><font color=#F92663>72.71</font></td>
<td><font color=#F92663>1.370</font></td>
<td><font color=#F92663>101.92%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q24a</font></td>
<td><font color=#6F9915>72.17</font></td>
<td><font color=#6F9915>69.58</font></td>
<td><font color=#6F9915>-2.591</font></td>
<td><font color=#6F9915>96.41%</font></td>
</tr>
<tr>
<td><font color=#F92663>q24b</font></td>
<td><font color=#F92663>68.27</font></td>
<td><font color=#F92663>68.38</font></td>
<td><font color=#F92663>0.110</font></td>
<td><font color=#F92663>100.16%</font></td>
</tr>
<tr>
<td><font color=#F92663>q25</font></td>
<td><font color=#F92663>5.07</font></td>
<td><font color=#F92663>5.79</font></td>
<td><font color=#F92663>0.722</font></td>
<td><font color=#F92663>114.25%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q26</font></td>
<td><font color=#6F9915>3.40</font></td>
<td><font color=#6F9915>2.26</font></td>
<td><font color=#6F9915>-1.144</font></td>
<td><font color=#6F9915>66.35%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q27</font></td>
<td><font color=#6F9915>2.94</font></td>
<td><font color=#6F9915>2.76</font></td>
<td><font color=#6F9915>-0.179</font></td>
<td><font color=#6F9915>93.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>q28</font></td>
<td><font color=#F92663>17.03</font></td>
<td><font color=#F92663>17.17</font></td>
<td><font color=#F92663>0.142</font></td>
<td><font color=#F92663>100.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q29</font></td>
<td><font color=#6F9915>8.07</font></td>
<td><font color=#6F9915>7.70</font></td>
<td><font color=#6F9915>-0.376</font></td>
<td><font color=#6F9915>95.34%</font></td>
</tr>
<tr>
<td><font color=#F92663>q30</font></td>
<td><font color=#F92663>5.59</font></td>
<td><font color=#F92663>5.78</font></td>
<td><font color=#F92663>0.194</font></td>
<td><font color=#F92663>103.47%</font></td>
</tr>
<tr>
<td><font color=#F92663>q31</font></td>
<td><font color=#F92663>7.68</font></td>
<td><font color=#F92663>8.43</font></td>
<td><font color=#F92663>0.749</font></td>
<td><font color=#F92663>109.75%</font></td>
</tr>
<tr>
<td><font color=#F92663>q32</font></td>
<td><font color=#F92663>1.65</font></td>
<td><font color=#F92663>1.67</font></td>
<td><font color=#F92663>0.017</font></td>
<td><font color=#F92663>101.00%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q33</font></td>
<td><font color=#6F9915>3.56</font></td>
<td><font color=#6F9915>3.26</font></td>
<td><font color=#6F9915>-0.301</font></td>
<td><font color=#6F9915>91.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q34</font></td>
<td><font color=#6F9915>4.53</font></td>
<td><font color=#6F9915>3.91</font></td>
<td><font color=#6F9915>-0.626</font></td>
<td><font color=#6F9915>86.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q35</font></td>
<td><font color=#6F9915>7.89</font></td>
<td><font color=#6F9915>7.78</font></td>
<td><font color=#6F9915>-0.104</font></td>
<td><font color=#6F9915>98.68%</font></td>
</tr>
<tr>
<td><font color=#F92663>q36</font></td>
<td><font color=#F92663>2.31</font></td>
<td><font color=#F92663>3.27</font></td>
<td><font color=#F92663>0.953</font></td>
<td><font color=#F92663>141.18%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q37</font></td>
<td><font color=#6F9915>3.26</font></td>
<td><font color=#6F9915>2.98</font></td>
<td><font color=#6F9915>-0.284</font></td>
<td><font color=#6F9915>91.29%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q38</font></td>
<td><font color=#6F9915>12.02</font></td>
<td><font color=#6F9915>11.14</font></td>
<td><font color=#6F9915>-0.877</font></td>
<td><font color=#6F9915>92.70%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q39a</font></td>
<td><font color=#6F9915>4.87</font></td>
<td><font color=#6F9915>4.34</font></td>
<td><font color=#6F9915>-0.532</font></td>
<td><font color=#6F9915>89.07%</font></td>
</tr>
<tr>
<td><font color=#F92663>q39b</font></td>
<td><font color=#F92663>3.43</font></td>
<td><font color=#F92663>3.82</font></td>
<td><font color=#F92663>0.396</font></td>
<td><font color=#F92663>111.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q40</font></td>
<td><font color=#6F9915>3.67</font></td>
<td><font color=#6F9915>3.56</font></td>
<td><font color=#6F9915>-0.110</font></td>
<td><font color=#6F9915>97.01%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q41</font></td>
<td><font color=#6F9915>0.62</font></td>
<td><font color=#6F9915>0.61</font></td>
<td><font color=#6F9915>-0.013</font></td>
<td><font color=#6F9915>97.93%</font></td>
</tr>
<tr>
<td><font color=#F92663>q42</font></td>
<td><font color=#F92663>1.44</font></td>
<td><font color=#F92663>1.57</font></td>
<td><font color=#F92663>0.133</font></td>
<td><font color=#F92663>109.23%</font></td>
</tr>
<tr>
<td><font color=#F92663>q43</font></td>
<td><font color=#F92663>2.02</font></td>
<td><font color=#F92663>2.08</font></td>
<td><font color=#F92663>0.060</font></td>
<td><font color=#F92663>102.95%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q44</font></td>
<td><font color=#6F9915>6.14</font></td>
<td><font color=#6F9915>5.86</font></td>
<td><font color=#6F9915>-0.284</font></td>
<td><font color=#6F9915>95.38%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q45</font></td>
<td><font color=#6F9915>4.47</font></td>
<td><font color=#6F9915>3.28</font></td>
<td><font color=#6F9915>-1.184</font></td>
<td><font color=#6F9915>73.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q46</font></td>
<td><font color=#F92663>3.97</font></td>
<td><font color=#F92663>4.28</font></td>
<td><font color=#F92663>0.313</font></td>
<td><font color=#F92663>107.87%</font></td>
</tr>
<tr>
<td><font color=#F92663>q47</font></td>
<td><font color=#F92663>9.75</font></td>
<td><font color=#F92663>9.87</font></td>
<td><font color=#F92663>0.118</font></td>
<td><font color=#F92663>101.21%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q48</font></td>
<td><font color=#6F9915>3.80</font></td>
<td><font color=#6F9915>3.30</font></td>
<td><font color=#6F9915>-0.500</font></td>
<td><font color=#6F9915>86.83%</font></td>
</tr>
<tr>
<td><font color=#F92663>q49</font></td>
<td><font color=#F92663>5.59</font></td>
<td><font color=#F92663>5.77</font></td>
<td><font color=#F92663>0.182</font></td>
<td><font color=#F92663>103.26%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q50</font></td>
<td><font color=#6F9915>17.48</font></td>
<td><font color=#6F9915>17.03</font></td>
<td><font color=#6F9915>-0.447</font></td>
<td><font color=#6F9915>97.44%</font></td>
</tr>
<tr>
<td><font color=#F92663>q51</font></td>
<td><font color=#F92663>7.11</font></td>
<td><font color=#F92663>7.30</font></td>
<td><font color=#F92663>0.193</font></td>
<td><font color=#F92663>102.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q52</font></td>
<td><font color=#F92663>1.28</font></td>
<td><font color=#F92663>1.31</font></td>
<td><font color=#F92663>0.029</font></td>
<td><font color=#F92663>102.27%</font></td>
</tr>
<tr>
<td><font color=#F92663>q53</font></td>
<td><font color=#F92663>1.69</font></td>
<td><font color=#F92663>1.88</font></td>
<td><font color=#F92663>0.190</font></td>
<td><font color=#F92663>111.27%</font></td>
</tr>
<tr>
<td><font color=#F92663>q54</font></td>
<td><font color=#F92663>5.54</font></td>
<td><font color=#F92663>6.46</font></td>
<td><font color=#F92663>0.920</font></td>
<td><font color=#F92663>116.61%</font></td>
</tr>
<tr>
<td><font color=#F92663>q55</font></td>
<td><font color=#F92663>0.58</font></td>
<td><font color=#F92663>1.63</font></td>
<td><font color=#F92663>1.045</font></td>
<td><font color=#F92663>278.97%</font></td>
</tr>
<tr>
<td><font color=#F92663>q56</font></td>
<td><font color=#F92663>4.02</font></td>
<td><font color=#F92663>4.10</font></td>
<td><font color=#F92663>0.081</font></td>
<td><font color=#F92663>102.01%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q57</font></td>
<td><font color=#6F9915>6.66</font></td>
<td><font color=#6F9915>6.58</font></td>
<td><font color=#6F9915>-0.083</font></td>
<td><font color=#6F9915>98.76%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q58</font></td>
<td><font color=#6F9915>3.06</font></td>
<td><font color=#6F9915>2.85</font></td>
<td><font color=#6F9915>-0.205</font></td>
<td><font color=#6F9915>93.28%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q59</font></td>
<td><font color=#6F9915>4.44</font></td>
<td><font color=#6F9915>3.93</font></td>
<td><font color=#6F9915>-0.513</font></td>
<td><font color=#6F9915>88.44%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q60</font></td>
<td><font color=#6F9915>5.51</font></td>
<td><font color=#6F9915>4.34</font></td>
<td><font color=#6F9915>-1.168</font></td>
<td><font color=#6F9915>78.78%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q61</font></td>
<td><font color=#6F9915>4.69</font></td>
<td><font color=#6F9915>4.04</font></td>
<td><font color=#6F9915>-0.653</font></td>
<td><font color=#6F9915>86.09%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q62</font></td>
<td><font color=#6F9915>2.74</font></td>
<td><font color=#6F9915>2.65</font></td>
<td><font color=#6F9915>-0.090</font></td>
<td><font color=#6F9915>96.72%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q63</font></td>
<td><font color=#6F9915>1.50</font></td>
<td><font color=#6F9915>1.35</font></td>
<td><font color=#6F9915>-0.159</font></td>
<td><font color=#6F9915>89.44%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q64</font></td>
<td><font color=#6F9915>35.57</font></td>
<td><font color=#6F9915>35.01</font></td>
<td><font color=#6F9915>-0.563</font></td>
<td><font color=#6F9915>98.42%</font></td>
</tr>
<tr>
<td><font color=#F92663>q65</font></td>
<td><font color=#F92663>11.09</font></td>
<td><font color=#F92663>11.68</font></td>
<td><font color=#F92663>0.596</font></td>
<td><font color=#F92663>105.38%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q66</font></td>
<td><font color=#6F9915>3.39</font></td>
<td><font color=#6F9915>2.64</font></td>
<td><font color=#6F9915>-0.753</font></td>
<td><font color=#6F9915>77.80%</font></td>
</tr>
<tr>
<td><font color=#F92663>q67</font></td>
<td><font color=#F92663>56.76</font></td>
<td><font color=#F92663>57.83</font></td>
<td><font color=#F92663>1.069</font></td>
<td><font color=#F92663>101.88%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q68</font></td>
<td><font color=#6F9915>3.35</font></td>
<td><font color=#6F9915>2.94</font></td>
<td><font color=#6F9915>-0.411</font></td>
<td><font color=#6F9915>87.71%</font></td>
</tr>
<tr>
<td><font color=#F92663>q69</font></td>
<td><font color=#F92663>4.89</font></td>
<td><font color=#F92663>5.34</font></td>
<td><font color=#F92663>0.450</font></td>
<td><font color=#F92663>109.20%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q70</font></td>
<td><font color=#6F9915>6.03</font></td>
<td><font color=#6F9915>5.54</font></td>
<td><font color=#6F9915>-0.490</font></td>
<td><font color=#6F9915>91.86%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q71</font></td>
<td><font color=#6F9915>4.81</font></td>
<td><font color=#6F9915>4.64</font></td>
<td><font color=#6F9915>-0.173</font></td>
<td><font color=#6F9915>96.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q72</font></td>
<td><font color=#F92663>20.12</font></td>
<td><font color=#F92663>20.89</font></td>
<td><font color=#F92663>0.770</font></td>
<td><font color=#F92663>103.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q73</font></td>
<td><font color=#6F9915>2.59</font></td>
<td><font color=#6F9915>2.49</font></td>
<td><font color=#6F9915>-0.105</font></td>
<td><font color=#6F9915>95.94%</font></td>
</tr>
<tr>
<td><font color=#F92663>q74</font></td>
<td><font color=#F92663>17.49</font></td>
<td><font color=#F92663>17.53</font></td>
<td><font color=#F92663>0.042</font></td>
<td><font color=#F92663>100.24%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q75</font></td>
<td><font color=#6F9915>22.65</font></td>
<td><font color=#6F9915>22.64</font></td>
<td><font color=#6F9915>-0.012</font></td>
<td><font color=#6F9915>99.95%</font></td>
</tr>
<tr>
<td><font color=#F92663>q76</font></td>
<td><font color=#F92663>6.68</font></td>
<td><font color=#F92663>6.90</font></td>
<td><font color=#F92663>0.223</font></td>
<td><font color=#F92663>103.34%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q77</font></td>
<td><font color=#6F9915>2.56</font></td>
<td><font color=#6F9915>2.38</font></td>
<td><font color=#6F9915>-0.179</font></td>
<td><font color=#6F9915>93.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q78</font></td>
<td><font color=#F92663>32.67</font></td>
<td><font color=#F92663>33.48</font></td>
<td><font color=#F92663>0.812</font></td>
<td><font color=#F92663>102.48%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q79</font></td>
<td><font color=#6F9915>3.61</font></td>
<td><font color=#6F9915>3.40</font></td>
<td><font color=#6F9915>-0.213</font></td>
<td><font color=#6F9915>94.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q80</font></td>
<td><font color=#F92663>10.00</font></td>
<td><font color=#F92663>10.11</font></td>
<td><font color=#F92663>0.107</font></td>
<td><font color=#F92663>101.07%</font></td>
</tr>
<tr>
<td><font color=#F92663>q81</font></td>
<td><font color=#F92663>6.42</font></td>
<td><font color=#F92663>7.07</font></td>
<td><font color=#F92663>0.648</font></td>
<td><font color=#F92663>110.08%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q82</font></td>
<td><font color=#6F9915>5.83</font></td>
<td><font color=#6F9915>5.23</font></td>
<td><font color=#6F9915>-0.596</font></td>
<td><font color=#6F9915>89.77%</font></td>
</tr>
<tr>
<td><font color=#F92663>q83</font></td>
<td><font color=#F92663>1.34</font></td>
<td><font color=#F92663>1.48</font></td>
<td><font color=#F92663>0.140</font></td>
<td><font color=#F92663>110.50%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q84</font></td>
<td><font color=#6F9915>2.99</font></td>
<td><font color=#6F9915>2.50</font></td>
<td><font color=#6F9915>-0.485</font></td>
<td><font color=#6F9915>83.75%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q85</font></td>
<td><font color=#6F9915>6.72</font></td>
<td><font color=#6F9915>6.18</font></td>
<td><font color=#6F9915>-0.542</font></td>
<td><font color=#6F9915>91.94%</font></td>
</tr>
<tr>
<td><font color=#F92663>q86</font></td>
<td><font color=#F92663>1.94</font></td>
<td><font color=#F92663>2.17</font></td>
<td><font color=#F92663>0.228</font></td>
<td><font color=#F92663>111.76%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q87</font></td>
<td><font color=#6F9915>11.72</font></td>
<td><font color=#6F9915>11.55</font></td>
<td><font color=#6F9915>-0.172</font></td>
<td><font color=#6F9915>98.54%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q88</font></td>
<td><font color=#6F9915>15.37</font></td>
<td><font color=#6F9915>15.04</font></td>
<td><font color=#6F9915>-0.330</font></td>
<td><font color=#6F9915>97.85%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q89</font></td>
<td><font color=#6F9915>2.84</font></td>
<td><font color=#6F9915>2.19</font></td>
<td><font color=#6F9915>-0.647</font></td>
<td><font color=#6F9915>77.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q90</font></td>
<td><font color=#6F9915>2.42</font></td>
<td><font color=#6F9915>2.05</font></td>
<td><font color=#6F9915>-0.367</font></td>
<td><font color=#6F9915>84.82%</font></td>
</tr>
<tr>
<td><font color=#F92663>q91</font></td>
<td><font color=#F92663>3.33</font></td>
<td><font color=#F92663>3.50</font></td>
<td><font color=#F92663>0.169</font></td>
<td><font color=#F92663>105.07%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q92</font></td>
<td><font color=#6F9915>1.87</font></td>
<td><font color=#6F9915>1.70</font></td>
<td><font color=#6F9915>-0.166</font></td>
<td><font color=#6F9915>91.10%</font></td>
</tr>
<tr>
<td><font color=#F92663>q93</font></td>
<td><font color=#F92663>23.05</font></td>
<td><font color=#F92663>23.27</font></td>
<td><font color=#F92663>0.220</font></td>
<td><font color=#F92663>100.95%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q94</font></td>
<td><font color=#6F9915>8.65</font></td>
<td><font color=#6F9915>8.57</font></td>
<td><font color=#6F9915>-0.079</font></td>
<td><font color=#6F9915>99.09%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>55.73</font></td>
<td><font color=#6F9915>55.63</font></td>
<td><font color=#6F9915>-0.091</font></td>
<td><font color=#6F9915>99.84%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>2.10</font></td>
<td><font color=#F92663>2.16</font></td>
<td><font color=#F92663>0.058</font></td>
<td><font color=#F92663>102.76%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q96</font></td>
<td><font color=#6F9915>10.93</font></td>
<td><font color=#6F9915>10.50</font></td>
<td><font color=#6F9915>-0.434</font></td>
<td><font color=#6F9915>96.03%</font></td>
</tr>
<tr>
<td><font color=#F92663>q97</font></td>
<td><font color=#F92663>2.13</font></td>
<td><font color=#F92663>2.91</font></td>
<td><font color=#F92663>0.775</font></td>
<td><font color=#F92663>136.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q98</font></td>
<td><font color=#6F9915>5.44</font></td>
<td><font color=#6F9915>5.09</font></td>
<td><font color=#6F9915>-0.353</font></td>
<td><font color=#6F9915>93.51%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q99</font></td>
<td><font color=#6F9915>0.36</font></td>
<td><font color=#6F9915>0.29</font></td>
<td><font color=#6F9915>-0.064</font></td>
<td><font color=#6F9915>81.96%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1174.41</font></td>
<td><font color=#6F9915>1160.27</font></td>
<td><font color=#6F9915>-14.140</font></td>
<td><font color=#6F9915>98.80%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2801778744
> If we need to load to GlutenSessionExtensions by default and we've provided a dynamic config to disable it
We load `GlutenSessionExtensions` only when `spark.plugins=org.apache.gluten.GlutenPlugin`. We have a dynamic config `spark.gluten.enabled` to disable Gluten but the option can take effect even after the extensions are injected. So it's implemented in the different way.
The PR is just to address a corner case that user accidentally specifies `spark.sql.extensions=org.apache.gluten.extension.GlutenSessionExtensions` manually which is not recommended. We'd make Gluten work normally in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2802474379
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_04_14_2025_time.csv</font></td>
<td><font color=#000000>log/native_master_04_13_2025_cb35706408_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>25.48</font></td>
<td><font color=#F92663>25.59</font></td>
<td><font color=#F92663>0.106</font></td>
<td><font color=#F92663>100.42%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>26.55</font></td>
<td><font color=#F92663>26.94</font></td>
<td><font color=#F92663>0.396</font></td>
<td><font color=#F92663>101.49%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>32.77</font></td>
<td><font color=#6F9915>32.60</font></td>
<td><font color=#6F9915>-0.166</font></td>
<td><font color=#6F9915>99.49%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>27.43</font></td>
<td><font color=#F92663>27.97</font></td>
<td><font color=#F92663>0.538</font></td>
<td><font color=#F92663>101.96%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>59.57</font></td>
<td><font color=#F92663>60.55</font></td>
<td><font color=#F92663>0.978</font></td>
<td><font color=#F92663>101.64%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.01</font></td>
<td><font color=#F92663>7.96</font></td>
<td><font color=#F92663>0.952</font></td>
<td><font color=#F92663>113.58%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>40.71</font></td>
<td><font color=#6F9915>40.34</font></td>
<td><font color=#6F9915>-0.372</font></td>
<td><font color=#6F9915>99.09%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>61.75</font></td>
<td><font color=#F92663>64.26</font></td>
<td><font color=#F92663>2.505</font></td>
<td><font color=#F92663>104.06%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>95.49</font></td>
<td><font color=#F92663>99.16</font></td>
<td><font color=#F92663>3.671</font></td>
<td><font color=#F92663>103.84%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>43.82</font></td>
<td><font color=#6F9915>42.56</font></td>
<td><font color=#6F9915>-1.260</font></td>
<td><font color=#6F9915>97.13%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>15.98</font></td>
<td><font color=#F92663>16.49</font></td>
<td><font color=#F92663>0.505</font></td>
<td><font color=#F92663>103.16%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>15.81</font></td>
<td><font color=#F92663>16.54</font></td>
<td><font color=#F92663>0.731</font></td>
<td><font color=#F92663>104.63%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>24.33</font></td>
<td><font color=#F92663>24.75</font></td>
<td><font color=#F92663>0.421</font></td>
<td><font color=#F92663>101.73%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>11.82</font></td>
<td><font color=#6F9915>11.54</font></td>
<td><font color=#6F9915>-0.280</font></td>
<td><font color=#6F9915>97.63%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>25.45</font></td>
<td><font color=#F92663>25.78</font></td>
<td><font color=#F92663>0.329</font></td>
<td><font color=#F92663>101.29%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>12.62</font></td>
<td><font color=#F92663>13.41</font></td>
<td><font color=#F92663>0.792</font></td>
<td><font color=#F92663>106.27%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>74.47</font></td>
<td><font color=#6F9915>73.07</font></td>
<td><font color=#6F9915>-1.397</font></td>
<td><font color=#6F9915>98.12%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>110.46</font></td>
<td><font color=#F92663>114.34</font></td>
<td><font color=#F92663>3.875</font></td>
<td><font color=#F92663>103.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>17.20</font></td>
<td><font color=#F92663>20.67</font></td>
<td><font color=#F92663>3.476</font></td>
<td><font color=#F92663>120.21%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>24.81</font></td>
<td><font color=#6F9915>23.17</font></td>
<td><font color=#6F9915>-1.642</font></td>
<td><font color=#6F9915>93.38%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>170.71</font></td>
<td><font color=#F92663>174.55</font></td>
<td><font color=#F92663>3.843</font></td>
<td><font color=#F92663>102.25%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>12.46</font></td>
<td><font color=#6F9915>10.20</font></td>
<td><font color=#6F9915>-2.253</font></td>
<td><font color=#6F9915>81.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>936.70</font></td>
<td><font color=#F92663>952.45</font></td>
<td><font color=#F92663>15.748</font></td>
<td><font color=#F92663>101.68%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2801256260
@yaooqinn Thank you for the inputs.
Though the static service file doesn't feel straightforward to work with `spark.plugins`? Which is the recommended way for enabling Gluten for Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2800879632
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer merged PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2801392996
If we need to load to `GlutenSessionExtensions` by default and we've provided a dynamic config to disable it, using SPI might be the best way. Besides, AFAIK, some cloud vendor platforms that provide Spark services are not that easy to load jars/extentions with configs.
BTW, `spark.plugins` hasn't provided SPI registration yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correct handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2800828257
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correctly handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2801046164
You can use SPI to load this extension instead of grabbing it with end-users
FYI, https://github.com/apache/spark/commit/51815430b289dc43eaf2d24b98a1597b73c7c163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [CORE] Correct handle driver configurations when `spark.sql.extensions` is explicitly set for GlutenSessionExtensions [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9312:
URL: https://github.com/apache/incubator-gluten/pull/9312#issuecomment-2800828855
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org