[jira] [Issue Comment Deleted] (IGNITE-2422) Unable to deserialize BinaryObjectBuilder

["Maksim Kozlov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IGNITE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maksim Kozlov updated IGNITE-2422:
----------------------------------
    Comment: was deleted

(was: [~dmagda] I'm sorry, hurried to the test.
{{BinaryObjectBuilder}} and {{BinaryObjectBuilderImpl}} classes are not checked {{Serializable.class.isAssignableFrom(cls)}} (true if a class implements serializable and false otherwise), so I thought it would be better to add a serializable and clonable in {{BinaryObjectBuilder}}.
Then it turns out that it is necessary to remove the check from the {{ClassesGenerator}} (I think it is not good)?)

> Unable to deserialize BinaryObjectBuilder
> -----------------------------------------
>
>                 Key: IGNITE-2422
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2422
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.5.0.final
>            Reporter: Denis Magda
>            Assignee: Maksim Kozlov
>              Labels: important
>             Fix For: 2.0
>
>         Attachments: ExampleNodeStartup.java
>
>
> Presently it's possible to serialize {{BinaryObjectBuilder}} but it will lead to the errors at deserialization stage.
> After a brief investigation I see that this happens because neither {{org.apache.ignite.binary.BinaryObjectBuilder}} nor {{org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl}} presents in {{META-INF/classnames.properties}} file.
> If you try to update {{ignite/modules/core/src/main/resources/META-INF/classnames.properties}} by building the project from scratch and copying-pasting generated content from built {{classnames.properties}}, then you will still see that there are still no entries for  {{org.apache.ignite.binary.BinaryObjectBuilder}} nor {org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl}}.
> Looks like that {{ClassesGenerator}} misses these and other possible classes by some reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)